You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/14 17:00:49 UTC
[GitHub] [superset] stevetracvc opened a new pull request, #21084: fix(native filters) groupby filter issue
stevetracvc opened a new pull request, #21084:
URL: https://github.com/apache/superset/pull/21084
### SUMMARY
There's an odd error when trying to use the groupby filter, resulting in "TypeError: Cannot read properties of undefined (reading 'length')"
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
broken:
<img width="813" alt="groupby_error_1" src="https://user-images.githubusercontent.com/70416691/184547239-167297fd-2b30-41d3-a7ae-6b389983d806.png">
works:
### TESTING INSTRUCTIONS
Create a new groupby filter on a dashboard and see how you get the black error boxes.
Full error message:
```
Oops! An error occurred!
TypeError: Cannot read properties of undefined (reading 'length')
Stack Trace:
in PluginFilterGroupBy (created by CustomLoadableRenderer)
in CustomLoadableRenderer (created by SuperChartCore)
in div (created by SuperChartCore)
in SuperChartCore (created by ParentSize)
in ErrorBoundary (created by ParentSize)
in div (created by ParentSize)
in ParentSize (created by SuperChart)
in div
in Unknown (created by SuperChart)
in SuperChart (created by WithTheme(SuperChart))
in WithTheme(SuperChart) (created by FilterValue)
in div (created by Styled(div))
in Styled(div) (created by FilterValue)
in FilterValue (created by FilterControl)
in div (created by FormItemInput)
in div (created by FormItemInput)
in div (created by Col)
in Col (created by FormItemInput)
in FormItemInput (created by FormItem)
in div (created by Row)
in Row (created by FormItem)
in FormItem (created by Styled(FormItem))
in Styled(FormItem) (created by FilterControl)
in div (created by Trigger)
in Trigger (created by ForwardRef(Tooltip))
in ForwardRef(Tooltip) (created by Tooltip)
in Tooltip (created by Popover)
in Popover (created by FilterCard)
in FilterCard (created by FilterControl)
in form (created by ForwardRef(Form))
in ForwardRef(Form) (created by ForwardRef(InternalForm))
in SizeContextProvider (created by ForwardRef(InternalForm))
in ForwardRef(InternalForm) (created by Styled(Component))
in Styled(Component) (created by Form)
in Form (created by Styled(Form))
in Styled(Form) (created by FilterControl)
in FilterControl (created by FilterControls)
in InPortal (created by FilterControls)
in div (created by Styled(div))
in Styled(div) (created by FilterControls)
in FilterControls (created by FilterBar)
in div (created by EmotionCssPropInternal)
in EmotionCssPropInternal (created by FilterBar)
in div (created by Styled(div))
in Styled(div) (created by FilterBar)
in div (created by Styled(div))
in Styled(div) (created by FilterBar)
in FilterBar (created by DashboardBuilder)
in ErrorBoundary (created by DashboardBuilder)
in div (created by Styled(div))
in Styled(div) (created by DashboardBuilder)
in div (created by Styled(div))
in Styled(div) (created by DashboardBuilder)
in div (created by Styled(div))
in Styled(div) (created by DashboardBuilder)
in DashboardBuilder (created by Dashboard)
in Dashboard (created by ConnectFunction)
in ConnectFunction (created by DashboardPage)
in DashboardPage (created by DashboardRoute)
in DashboardRoute (created by App)
in ErrorBoundary (created by App)
in Suspense (created by App)
in Route (created by App)
in Switch (created by App)
in LocationProvider (created by Context.Consumer)
in Route (created by QueryParamProvider)
in QueryParamProvider (created by RootContextProviders)
in DynamicPluginProvider (created by RootContextProviders)
in EmbeddedUiConfigProvider (created by RootContextProviders)
in FlashProvider (created by RootContextProviders)
in Unknown (created by RootContextProviders)
in Provider (created by RootContextProviders)
in ThemeProvider (created by RootContextProviders)
in RootContextProviders (created by App)
in Router (created by BrowserRouter)
in BrowserRouter (created by App)
in App
```
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #21084: fix(native filters): groupby filter issue
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged PR #21084:
URL: https://github.com/apache/superset/pull/21084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stevetracvc commented on pull request #21084: fix(native filters): groupby filter issue
Posted by GitBox <gi...@apache.org>.
stevetracvc commented on PR #21084:
URL: https://github.com/apache/superset/pull/21084#issuecomment-1214415735
I didn't dig into _why_ this fixes it, as you'd expect that array to not be empty. But it does appear to fix it. Might mean there's an underlying problem somewhere else.
Old Slack thread discussing it a bit.
https://apache-superset.slack.com/archives/C016B3LG5B4/p1643044538072600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21084: fix(native filters): groupby filter issue
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21084:
URL: https://github.com/apache/superset/pull/21084#issuecomment-1214423902
# [Codecov](https://codecov.io/gh/apache/superset/pull/21084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21084](https://codecov.io/gh/apache/superset/pull/21084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c517d2d) into [master](https://codecov.io/gh/apache/superset/commit/394d62ee51b6feb6e23c2b24505ee469460db146?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (394d62e) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #21084 +/- ##
=======================================
Coverage 66.27% 66.27%
=======================================
Files 1770 1770
Lines 67524 67524
Branches 7178 7178
=======================================
Hits 44754 44754
Misses 20936 20936
Partials 1834 1834
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.00% <0.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...filters/components/GroupBy/GroupByFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/21084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L0dyb3VwQnlGaWx0ZXJQbHVnaW4udHN4) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org