You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by xunzhang <gi...@git.apache.org> on 2016/09/13 07:01:07 UTC
[GitHub] incubator-hawq pull request #900: HAWQ-1033. Combine update and insert into ...
GitHub user xunzhang opened a pull request:
https://github.com/apache/incubator-hawq/pull/900
HAWQ-1033. Combine update and insert into one transaction, fix hadoop warning.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xunzhang/incubator-hawq register
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/900.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #900
----
commit 682aa64190925df2be52a2d0881bd9e3bd3c2cf4
Author: xunzhang <xu...@gmail.com>
Date: 2016-09-13T06:41:45Z
HAWQ-1033. Combine update and insert into one transaction, fix hadoop warning.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #900: HAWQ-1033. Combine update and insert into ...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang closed the pull request at:
https://github.com/apache/incubator-hawq/pull/900
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #900: HAWQ-1033. Combine update and insert into ...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/900#discussion_r78570237
--- Diff: tools/bin/hawqregister ---
@@ -460,12 +460,13 @@ if __name__ == '__main__':
do_not_move, files_update, sizes_update = True, files, sizes
files, sizes = [], []
else:
- for k, f in enumerate(files):
--- End diff --
The old code here is wrong: it is risky to iterate a changing object.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #900: HAWQ-1033. Combine update and insert into one tra...
Posted by wcl14 <gi...@git.apache.org>.
Github user wcl14 commented on the issue:
https://github.com/apache/incubator-hawq/pull/900
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #900: HAWQ-1033. Combine update and insert into one tra...
Posted by ictmalili <gi...@git.apache.org>.
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/900
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #900: HAWQ-1033. Combine update and insert into ...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/900#discussion_r78686806
--- Diff: tools/bin/hawqregister ---
@@ -373,8 +402,8 @@ if __name__ == '__main__':
if len(args) != 1 or ((options.yml_config or options.force or options.repair) and options.filepath) or (options.force and options.repair):
parser.print_help(sys.stderr)
sys.exit(1)
- if local_ssh('hadoop', logger):
- logger.error('command "hadoop" is not available.')
+ if local_ssh('hdfs', logger):
+ logger.error('command "hdfs" is not available.')
--- End diff --
We do not try to predict the problem in user side,
here I only want to return to users the reason why register can not work. Thanks anyway for the volunteer review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #900: HAWQ-1033. Combine update and insert into one tra...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:
https://github.com/apache/incubator-hawq/pull/900
cc @ictmalili @zhangh43 @linwen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #900: HAWQ-1033. Combine update and insert into one tra...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:
https://github.com/apache/incubator-hawq/pull/900
Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #900: HAWQ-1033. Combine update and insert into one tra...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:
https://github.com/apache/incubator-hawq/pull/900
also cc @wcl14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #900: HAWQ-1033. Combine update and insert into ...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/900#discussion_r78569975
--- Diff: tools/bin/hawqregister ---
@@ -460,12 +460,13 @@ if __name__ == '__main__':
do_not_move, files_update, sizes_update = True, files, sizes
files, sizes = [], []
else:
- for k, f in enumerate(files):
+ files_old, sizes_old = [f for f in files], [sz for sz in sizes]
--- End diff --
Notice here, alternative modification like `files_old, sizes_old = files, sizes` is wrong since python default copy is not a deep copy, it is just a pointer copy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #900: HAWQ-1033. Combine update and insert into ...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/900#discussion_r78670438
--- Diff: tools/bin/hawqregister ---
@@ -373,8 +402,8 @@ if __name__ == '__main__':
if len(args) != 1 or ((options.yml_config or options.force or options.repair) and options.filepath) or (options.force and options.repair):
parser.print_help(sys.stderr)
sys.exit(1)
- if local_ssh('hadoop', logger):
- logger.error('command "hadoop" is not available.')
+ if local_ssh('hdfs', logger):
+ logger.error('command "hdfs" is not available.')
--- End diff --
Maybe you could be more accurate (e.g. "Maybe the hdfs path is not in the shell environment variable PATH" or similar).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---