You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/07/13 06:36:39 UTC
[GitHub] [ozone] ChenSammi commented on a change in pull request #2397: HDDS-5403 Support list node based on NodeOperationalState and NodeState options in datanode list CLI
ChenSammi commented on a change in pull request #2397:
URL: https://github.com/apache/ozone/pull/2397#discussion_r668468319
##########
File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/ListInfoSubcommand.java
##########
@@ -51,6 +51,19 @@
defaultValue = "")
private String uuid;
+ @CommandLine.Option(names = {"--NodeOperationalState"},
+ description = "Show info by datanode NodeOperationalState." +
+ "IN_SERVICE DECOMMISSIONING DECOMMISSIONED ENTERING_MAINTENANCE" +
Review comment:
Please change the description to the following format "Show info by datanode NodeOperationalState(IN_SERVICE, DECOMMISSIONING, DECOMMISSIONED, ENTERING_MAINTENANCE, IN_MAINTENANCE)."
##########
File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/ListInfoSubcommand.java
##########
@@ -51,6 +51,19 @@
defaultValue = "")
private String uuid;
+ @CommandLine.Option(names = {"--NodeOperationalState"},
+ description = "Show info by datanode NodeOperationalState." +
+ "IN_SERVICE DECOMMISSIONING DECOMMISSIONED ENTERING_MAINTENANCE" +
+ "IN_MAINTENANCE",
+ defaultValue = "")
+ private String nodeOperationalState;
+
+ @CommandLine.Option(names = {"--NodeState"},
+ description = "Show info by datanode NodeState." +
+ " HEALTHY STALE DEAD",
Review comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org