You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "moleske (GitHub)" <gi...@apache.org> on 2019/12/03 23:43:32 UTC
[GitHub] [geode] moleske opened pull request #4408: Fix LGTM
InternalLocator Container Never Accessed Issue
Along with other cleanup
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/4408 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] lgtm-com[bot] commented on issue #4408: GEODE-7558:
Fix LGTM InternalLocator Container Never Accessed Issue
Posted by lg...@gitbox.apache.org.
This pull request **fixes 1 alert** when merging 47893d0caacd7aa416e48ccb99f70ee1d358c701 into 98e75f4acfea3d5ecf5630429899aa20fd3b21cd - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-af8f9827992997431f005e41b8c6fe7072bcce7b)
**fixed alerts:**
* 1 for Container contents are never accessed
[ Full content available at: https://github.com/apache/geode/pull/4408 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] lgtm-com[bot] commented on issue #4408: GEODE-7558:
Fix LGTM InternalLocator Container Never Accessed Issue
Posted by lg...@gitbox.apache.org.
This pull request **fixes 1 alert** when merging 70df75ffa01873d7e524ffa71ba46ea29c3ee1b5 into 82837af8d5bda26cb81c2d85f172c07499d1ed52 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-c3219cf068179c8750144f32cec9c2466fbec9fd)
**fixed alerts:**
* 1 for Container contents are never accessed
[ Full content available at: https://github.com/apache/geode/pull/4408 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] moleske closed pull request #4408: GEODE-7558: Fix
LGTM InternalLocator Container Never Accessed Issue
Posted by "moleske (GitHub)" <gi...@apache.org>.
[ pull request closed by moleske ]
[ Full content available at: https://github.com/apache/geode/pull/4408 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] moleske commented on issue #4408: GEODE-7558: Fix
LGTM InternalLocator Container Never Accessed Issue
Posted by "moleske (GitHub)" <gi...@apache.org>.
Reverting the deprecation since we support upgrading from any minor to another minor, and this name change would break that
[ Full content available at: https://github.com/apache/geode/pull/4408 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] lgtm-com[bot] commented on issue #4408: GEODE-7558:
Fix LGTM InternalLocator Container Never Accessed Issue
Posted by lg...@gitbox.apache.org.
This pull request **fixes 1 alert** when merging f166d9fa19d9b8959ca73cafd1084c1d2eeb8bab into 51d1b245643e97c0f92bd39abe89e8e744d476cf - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-1f64b420b41ccb858ce94295cb9be5dbda42a166)
**fixed alerts:**
* 1 for Container contents are never accessed
[ Full content available at: https://github.com/apache/geode/pull/4408 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org