You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mahout.apache.org by "guan404ming (via GitHub)" <gi...@apache.org> on 2026/02/09 09:41:02 UTC
[PR] Simplify issue and pr templates [mahout]
guan404ming opened a new pull request, #1038:
URL: https://github.com/apache/mahout/pull/1038
### Purpose of PR
Current template is kind of complex to use and this pr try to simply it to keep essential info.
### Related Issues or PRs
<!-- Add links to related issues or PRs. -->
<!-- - Closes #123 -->
<!-- - Related to #123 -->
### Changes Made
<!-- Please mark one with an "x" -->
- [ ] Bug fix
- [ ] New feature
- [ ] Refactoring
- [x] Documentation
- [ ] Test
- [ ] CI/CD pipeline
- [ ] Other
### Breaking Changes
<!-- Does this PR introduce a breaking change? -->
- [ ] Yes
- [x] No
### Checklist
<!-- Please mark each item with an "x" when complete -->
<!-- If not all items are complete, please open this as a **Draft PR**.
Once all requirements are met, mark as ready for review. -->
- [x] Added or updated unit tests for all changes
- [x] Added or updated documentation for all changes
- [x] Successfully built and ran all unit tests or manual tests locally
- [ ] PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
- [x] Code follows ASF guidelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify issue and pr templates [mahout]
Posted by "rawkintrevo (via GitHub)" <gi...@apache.org>.
rawkintrevo commented on PR #1038:
URL: https://github.com/apache/mahout/pull/1038#issuecomment-3873363534
lgtm - just left two notes in comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify issue and pr templates [mahout]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #1038:
URL: https://github.com/apache/mahout/pull/1038#discussion_r2785391154
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -16,18 +12,10 @@
- [ ] CI/CD pipeline
- [ ] Other
-### Breaking Changes
-<!-- Does this PR introduce a breaking change? -->
-- [ ] Yes
-- [ ] No
+### Why
+
+<!-- Why is this change needed? -->
-### Checklist
-<!-- Please mark each item with an "x" when complete -->
-<!-- If not all items are complete, please open this as a **Draft PR**.
-Once all requirements are met, mark as ready for review. -->
+### How
-- [ ] Added or updated unit tests for all changes
-- [ ] Added or updated documentation for all changes
-- [ ] Successfully built and ran all unit tests or manual tests locally
-- [ ] PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
-- [ ] Code follows ASF guidelines
Review Comment:
Thanks for the notification There is no those checklist in Airflow and we got some ci to check ASF header in each files so I think we could safely remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify issue and pr templates [mahout]
Posted by "rawkintrevo (via GitHub)" <gi...@apache.org>.
rawkintrevo commented on code in PR #1038:
URL: https://github.com/apache/mahout/pull/1038#discussion_r2784083850
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -16,18 +12,10 @@
- [ ] CI/CD pipeline
- [ ] Other
-### Breaking Changes
-<!-- Does this PR introduce a breaking change? -->
-- [ ] Yes
-- [ ] No
+### Why
+
+<!-- Why is this change needed? -->
-### Checklist
-<!-- Please mark each item with an "x" when complete -->
-<!-- If not all items are complete, please open this as a **Draft PR**.
-Once all requirements are met, mark as ready for review. -->
+### How
-- [ ] Added or updated unit tests for all changes
-- [ ] Added or updated documentation for all changes
-- [ ] Successfully built and ran all unit tests or manual tests locally
-- [ ] PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
-- [ ] Code follows ASF guidelines
Review Comment:
I thought this was required by asf. It may not be (or maybe it was once but isn't now) if it's not on the airflow one, it's probably fine to delete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify issue and pr templates [mahout]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #1038:
URL: https://github.com/apache/mahout/pull/1038#issuecomment-3882974611
I think we could add them back if we found anything is needed in the furture!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify issue and pr templates [mahout]
Posted by "rawkintrevo (via GitHub)" <gi...@apache.org>.
rawkintrevo commented on code in PR #1038:
URL: https://github.com/apache/mahout/pull/1038#discussion_r2784085564
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -16,18 +12,10 @@
- [ ] CI/CD pipeline
- [ ] Other
-### Breaking Changes
-<!-- Does this PR introduce a breaking change? -->
-- [ ] Yes
-- [ ] No
+### Why
+
+<!-- Why is this change needed? -->
-### Checklist
-<!-- Please mark each item with an "x" when complete -->
-<!-- If not all items are complete, please open this as a **Draft PR**.
-Once all requirements are met, mark as ready for review. -->
+### How
-- [ ] Added or updated unit tests for all changes
-- [ ] Added or updated documentation for all changes
Review Comment:
just make sure people are adding unit tests and docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify issue and pr templates [mahout]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on code in PR #1038:
URL: https://github.com/apache/mahout/pull/1038#discussion_r2785374555
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -16,18 +12,10 @@
- [ ] CI/CD pipeline
- [ ] Other
-### Breaking Changes
-<!-- Does this PR introduce a breaking change? -->
-- [ ] Yes
-- [ ] No
+### Why
+
+<!-- Why is this change needed? -->
-### Checklist
-<!-- Please mark each item with an "x" when complete -->
-<!-- If not all items are complete, please open this as a **Draft PR**.
-Once all requirements are met, mark as ready for review. -->
+### How
-- [ ] Added or updated unit tests for all changes
-- [ ] Added or updated documentation for all changes
-- [ ] Successfully built and ran all unit tests or manual tests locally
-- [ ] PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
-- [ ] Code follows ASF guidelines
Review Comment:
agree!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify issue and pr templates [mahout]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #1038:
URL: https://github.com/apache/mahout/pull/1038#discussion_r2785394603
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -16,18 +12,10 @@
- [ ] CI/CD pipeline
- [ ] Other
-### Breaking Changes
-<!-- Does this PR introduce a breaking change? -->
-- [ ] Yes
-- [ ] No
+### Why
+
+<!-- Why is this change needed? -->
-### Checklist
-<!-- Please mark each item with an "x" when complete -->
-<!-- If not all items are complete, please open this as a **Draft PR**.
-Once all requirements are met, mark as ready for review. -->
+### How
-- [ ] Added or updated unit tests for all changes
-- [ ] Added or updated documentation for all changes
Review Comment:
Just updated, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify issue and pr templates [mahout]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming merged PR #1038:
URL: https://github.com/apache/mahout/pull/1038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org