You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/28 05:33:00 UTC

[jira] [Commented] (WEEX-152) Memory usage optimization for box-shadow on Android

    [ https://issues.apache.org/jira/browse/WEEX-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268144#comment-16268144 ] 

ASF GitHub Bot commented on WEEX-152:
-------------------------------------

GitHub user misakuo opened a pull request:

    https://github.com/apache/incubator-weex/pull/917

    [WEEX-152][Android] clear box-shadow when component has recycled

    Testcase:
    http://dotwe.org/vue/335052b10f77ccd2cc31f0468fe77f32
    
    Before optimization:
    ![img](https://img.alicdn.com/tfs/TB1_PW_fxrI8KJjy0FpXXb5hVXa-1496-590.png)
    
    After optimization:
    ![img](https://img.alicdn.com/tfs/TB1ZpHqfr_I8KJjy1XaXXbsxpXa-1544-590.png)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/misakuo/incubator-weex android-feature-shadow-optimized

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/917.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #917
    
----
commit b3fb51c439bcf2c09a0fd1da5f27165028bfafc1
Author: misakuo <mi...@apache.org>
Date:   2017-11-13T03:37:08Z

    * [android] clear box-shadow when component has recycled
    
    (cherry picked from commit 7e97efc)

----


> Memory usage optimization for box-shadow on Android
> ---------------------------------------------------
>
>                 Key: WEEX-152
>                 URL: https://issues.apache.org/jira/browse/WEEX-152
>             Project: Weex
>          Issue Type: Wish
>          Components: Android
>            Reporter: moxun
>            Assignee: moxun
>
> Now the box-shadow on Android is host on Bitmap that added to ViewOverlay, we should recycle Bitmap at the right to save memory



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)