You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "janpio (GitHub)" <gi...@apache.org> on 2018/08/27 07:46:59 UTC

[GitHub] [cordova-cli] janpio opened issue #304: New command `cordova outdated`

... which is just `npm outdated` filtered down to only include platforms and plugins that are relevant to Cordova, not other Framework packages or similar.

This enables us to tell people to just run `cordova outdated` to learn what they have to update to get to a current state of all their libraries.

[ Full content available at: https://github.com/apache/cordova-cli/issues/304 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [cordova-cli] dpogue commented on issue #304: New command `cordova outdated`

Posted by "dpogue (GitHub)" <gi...@apache.org>.
> Ugh, I just learned that not all projects have their platforms and plugins in `package.json` which means that `npm outdated` may not know enough (yet?).

The next version of Cordova will not support having platforms/plugins in `config.xml`. Everything will need to be in `package.json`.

[ Full content available at: https://github.com/apache/cordova-cli/issues/304 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [cordova-cli] raphinesse commented on issue #304: New command `cordova outdated`

Posted by "raphinesse (GitHub)" <gi...@apache.org>.
Will this replace `cordova platform check`?

[ Full content available at: https://github.com/apache/cordova-cli/issues/304 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [cordova-cli] raphinesse commented on issue #304: New command `cordova outdated`

Posted by "raphinesse (GitHub)" <gi...@apache.org>.
> Possibly, I don't really know what exactly it does and how it works internally.

It's horrible code and I'm not surprised that it's horribly broken. Incidentally, there's a PR where I tried to cleanup the code a tiny bit: https://github.com/apache/cordova-lib/pull/650. But I would be happy to ditch it altogether. I actually suggested replacing it with something like `npm outdated | grep cordova` in the major release planning doc. It actually does a bit more than that, but not particularly well.

--- 

> Is `cordova platform update` still really a thing? 

Apparently so. In the face to face meeting, @purplecabbage talked about having done some work-in-progress to improve it. I guess it's important for workflows that do not treat the `platforms` directory as purely generated artifacts :man_shrugging: 

--- 

> Is [`cordova platform check`] maybe also broken anyway?

I dare you, take a look at the code. It would surprise me if it wasn't broken :grin: 

--- 

> What `platform check` definitely does not do is cover the CLI itself and plugins, which a filtered result set from `npm outdated` could do.

I agree. I think it would be good to have that. We should keep it simple, though. No plugin version conflict resolution or trying to install platforms like `platform check` does.

---

> Ugh, I just learned that not all projects have their platforms and plugins in package.json which means that npm outdated may not know enough (yet?).

Progressive enhancement? Could be an incentive to switch to more modern workflow. We should maybe also be clear about what kind of project setups and workflows we want to continue to support.

[ Full content available at: https://github.com/apache/cordova-cli/issues/304 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [cordova-cli] janpio commented on issue #304: New command `cordova outdated`

Posted by "janpio (GitHub)" <gi...@apache.org>.
Ugh, I just learned that not all projects have their platforms and plugins in `package.json` which means that `npm outdated` may not know enough (yet?).

[ Full content available at: https://github.com/apache/cordova-cli/issues/304 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [cordova-cli] raphinesse commented on issue #304: New command `cordova outdated`

Posted by "raphinesse (GitHub)" <gi...@apache.org>.
> Possibly, I don't really know what exactly it does and how it works internally.

It's horrible code and I'm not surprised that it's horribly broken. Incidentally, there's a PR where I tried to cleanup the code a tiny bit: #650. But I would be happy to ditch it altogether. I actually suggested replacing it with something like `npm outdated | grep cordova` in the major release planning doc. It actually does a bit more than that, but not particularly well.

--- 

> Is `cordova platform update` still really a thing? 

Apparently so. In the face to face meeting, @purplecabbage talked about having done some work-in-progress to improve it. I guess it's important for workflows that do not treat the `platforms` directory as purely generated artifacts :man_shrugging: 

--- 

> Is [`cordova platform check`] maybe also broken anyway?

I dare you, take a look at the code. It would surprise me if it wasn't broken :grin: 

--- 

> What `platform check` definitely does not do is cover the CLI itself and plugins, which a filtered result set from `npm outdated` could do.

I agree. I think it would be good to have that. We should keep it simple, though. No plugin version conflict resolution or trying to install platforms like `platform check` does.

---

> Ugh, I just learned that not all projects have their platforms and plugins in package.json which means that npm outdated may not know enough (yet?).

Progressive enhancement? Could be an incentive to switch to more modern workflow. We should maybe also be clear about what kind of project setups and workflows we want to continue to support.

[ Full content available at: https://github.com/apache/cordova-cli/issues/304 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [cordova-cli] janpio commented on issue #304: New command `cordova outdated`

Posted by "janpio (GitHub)" <gi...@apache.org>.
Possibly, I don't really know what exactly it does and how it works internally.

--- 

> check = List platforms which can be updated via cordova-cli with the command `platform update`

I `cordova platform update` still really a thing? 

--- 

Is it maybe also broken anyway? `cordova platform check` returns this for me:
```
λ cordova platform check
android @ 7.1.1; current did not install, and thus its version cannot be determined
ios @ 4.5.5; current did not install, and thus its version cannot be determined
```
both platforms are installed as usual and work just fine.

--- 

What `platform check` definitely does not do is cover the CLI itself and plugins, which a filtered resultset from `npm outdated` could do.

[ Full content available at: https://github.com/apache/cordova-cli/issues/304 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [cordova-cli] raphinesse commented on issue #304: New command `cordova outdated`

Posted by "raphinesse (GitHub)" <gi...@apache.org>.
> Possibly, I don't really know what exactly it does and how it works internally.

It's horrible code and I'm not surprised that it's horribly broken. Incidentally, there's a PR where I tried to cleanup the code a tiny bit: https://github.com/apache/cordova-lib/pull/650. But I would be happy to ditch it altogether. I actually suggested replacing it with something like `npm outdated | grep cordova` in the major release planning doc. It does a bit more than that, but not particularly well.

--- 

> Is `cordova platform update` still really a thing? 

Apparently so. In the face to face meeting, @purplecabbage talked about having done some work-in-progress to improve it. I guess it's important for workflows that do not treat the `platforms` directory as purely generated artifacts :man_shrugging: 

--- 

> Is [`cordova platform check`] maybe also broken anyway?

I dare you, take a look at the code. It would surprise me if it wasn't broken :grin: 

--- 

> What `platform check` definitely does not do is cover the CLI itself and plugins, which a filtered result set from `npm outdated` could do.

I agree. I think it would be good to have that. We should keep it simple, though. No plugin version conflict resolution or trying to install platforms like `platform check` does.

---

> Ugh, I just learned that not all projects have their platforms and plugins in package.json which means that npm outdated may not know enough (yet?).

Progressive enhancement? Could be an incentive to switch to more modern workflow. We should maybe also be clear about what kind of project setups and workflows we want to continue to support.

[ Full content available at: https://github.com/apache/cordova-cli/issues/304 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org