[GitHub] [pulsar] nodece commented on pull request #17208: [improve][build] Avoid building image multiple times

[GitBox <gi...@apache.org>]

nodece commented on PR #17208:
URL: https://github.com/apache/pulsar/pull/17208#issuecomment-1223644176

   > I think it's a bad idea to remove tagging with ${project.version} since some custom build could be relying on that.
   
   As far as I know, we didn't use `${project.version}` image, if you know where using that, please let me know, thanks!
   
   > This PR should be limited to the change that just removes the unnecessary duplication docker build (which seems to be prevented by Docker caching).
   
   You are right! But the docker-maven plugin only supports renewing an image name by rebuilding, or using https://dmp.fabric8.io/#docker:tag, but it only supports adding an image name.
   
   > which seems to be prevented by Docker caching
   
   Multiple builds can use caching, see https://github.com/apache/pulsar/runs/7945037366?check_suite_focus=true#step:10:6768, this PR just wants to avoid the multiple builds.
   
   
   We just enable `noCache` when building the test image. The pulsar, and pulsar-all images always use caching.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org