[PR] Implement From for i256 [arrow-rs]

["AdamGS (via GitHub)" <gi...@apache.org>]

AdamGS opened a new pull request, #10081:
URL: https://github.com/apache/arrow-rs/pull/10081

   # Which issue does this PR close?
   
   - Closes #10080.
   
   # Rationale for this change
   
   `From` is already implemented for all other signed integer primitives, ran into it working on decimal aggregations in DataFusion, which this will make much simpler.
   
   # What changes are included in this PR?
   
   Adds an additional trait implementation for i256. I've also considered deprecating `i256::from_i128` as a public function, but figured I'll see what reviewers think.
   
   # Are these changes tested?
   
   Just exposes an additional path for existing functionality.
   
   # Are there any user-facing changes?
   
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Implement From for i256 [arrow-rs]

["alamb (via GitHub)" <gi...@apache.org>]

alamb merged PR #10081:
URL: https://github.com/apache/arrow-rs/pull/10081


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org