[GitHub] [hbase] ramkrish86 commented on a change in pull request #939: HBASE-23349 : Config based Scanner reset after compaction if low refCount is preventing archival of compacted away store files

[GitBox <gi...@apache.org>]

ramkrish86 commented on a change in pull request #939: HBASE-23349 : Config based Scanner reset after compaction if low refCount is preventing archival of compacted away store files
URL: https://github.com/apache/hbase/pull/939#discussion_r364564366
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
 ##########
 @@ -157,6 +158,15 @@
   private final ReentrantLock flushLock = new ReentrantLock();
   // lock for closing.
   private final ReentrantLock closeLock = new ReentrantLock();
+  // scanner reset lock - ensure scanners are reopened only on new store files(non compacted)
+  private final ReentrantLock compactionLock = new ReentrantLock();
 
 Review comment:
   We still need two different locks here ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services