[GitHub] [samza] prateekm commented on a change in pull request #1296: SAMZA-2475: Add a allocated resource expiry timeout in samza yarn type of apps

[GitBox <gi...@apache.org>]

prateekm commented on a change in pull request #1296: SAMZA-2475: Add a allocated resource expiry timeout in samza yarn type of apps
URL: https://github.com/apache/samza/pull/1296#discussion_r387185218
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/clustermanager/ContainerManager.java
 ##########
 @@ -290,6 +290,29 @@ void handleExpiredRequest(String processorId, String preferredHost,
     }
   }
 
+  /**
+   * Handles expired allocated resource by requesting the same resource again and release the expired allocated resource
+   *
+   * @param request pending request for the preferred host
+   * @param resource resource allocated from {@link ClusterResourceManager} which has expired
+   * @param preferredHost host on which container is requested to be deployed
+   * @param resourceRequestState state of request in {@link ContainerAllocator}
+   * @param allocator allocator for requesting resources
+   */
+  void handleExpiredResource(SamzaResourceRequest request, SamzaResource resource, String preferredHost,
+      ResourceRequestState resourceRequestState, ContainerAllocator allocator) {
+    LOG.info("Allocated resource {} has been expired for Processor ID: {} request: {} re-requesting resource again",
 
 Review comment:
   "has expired"  "{}. Re-requesting again"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services