[GitHub] [incubator-druid] ilhanadiyaman commented on a change in pull request #8244: Update docker build

[GitBox <gi...@apache.org>]

ilhanadiyaman commented on a change in pull request #8244: Update docker build
URL: https://github.com/apache/incubator-druid/pull/8244#discussion_r311231880
 
 

 ##########
 File path: distribution/docker/druid.sh
 ##########
 @@ -45,45 +45,56 @@ echo "$(date -Is) startup service $SERVICE"
 
 # We put all the config in /tmp/conf to allow for a
 # read-only root filesystem
-cp -r /opt/druid/conf /tmp/conf
+mkdir -p /tmp/conf/
+cp -r /opt/druid/conf/druid /tmp/conf/druid
+
+getConfPath() {
+    cluster_conf_base=/tmp/conf/druid/cluster
+    case "$1" in
+    _common) echo $cluster_conf_base/_common ;;
+    historical) echo $cluster_conf_base/data/historical ;;
+    middleManager) echo $cluster_conf_base/data/middleManager ;;
+    coordinator | overlord) echo $cluster_conf_base/master/coordinator-overlord ;;
 
 Review comment:
   @himanshug thanks for detailed explanations. Yes, indeed the reason is to make the setup as fast as possible with minimum configuration. That's why we use the example configuration file from [coordinator and overlord](https://github.com/apache/incubator-druid/blob/master/examples/conf/druid/cluster/master/coordinator-overlord/runtime.properties).
   
   I think it is possible to run standalone coordinator process and standalone overlord process with this setup. You can check the [docker-compose.yml](https://github.com/apache/incubator-druid/blob/master/distribution/docker/docker-compose.yml). It's running both of them separately. Moreover, you can pass the full path of the configuration file per service as an environment variable.
   
   `DRUID_CONFIG_${service} -- full path to a file for druid 'service' properties`
   
   That said, because of the line `druid.coordinator.asOverlord.enabled=true` in the example config file, coordinator process might run Overlord process as well. I didn't check if there're any consequences of this setup but so far I didn't have any problems. Maybe we shouldn't use the example configuration files at all. But then it will put some learning process for people to understand and create the configuration files by themselves.
   
   What do you think? Any ides that we can improve the process?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org