You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by arteam <gi...@git.apache.org> on 2017/11/22 15:54:22 UTC
[GitHub] maven-scm pull request #56: [SCM-739] Use shallow clones when cloning a git ...
GitHub user arteam opened a pull request:
https://github.com/apache/maven-scm/pull/56
[SCM-739] Use shallow clones when cloning a git repo
For `maven-release-plugin` we don't need the whole history, but only the top commit. Using `--depth 1` allows to perform releases much faster on repositories with a long history.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arteam/maven-scm git-clone-shallow
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-scm/pull/56.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #56
----
commit c041868bf8c543cecb34c8f002f02438e6f81b52
Author: Artem Prigoda <ar...@gmail.com>
Date: 2017-11-22T15:52:00Z
[SCM-739] Use shallow clones when cloning a git repo
For `maven-release-plugin` we don't need the whole history, but
only the top commit. Using `--depth 1` allows to perform releases
much faster on repositories with a long history.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-scm issue #56: [SCM-739] Use shallow clones when cloning a git repo
Posted by arteam <gi...@git.apache.org>.
Github user arteam commented on the issue:
https://github.com/apache/maven-scm/pull/56
I like the proposal, but I am a a little bit confused. Does the new parameter should be added to the `executeCheckOutCommand` method (like `recursive`) and be implemented by the all `AbstractCheckOutCommand` implementations or should it be a field in `GitCheckOutCommand`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-scm pull request #56: [SCM-739] Use shallow clones when cloning a git ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/maven-scm/pull/56
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-scm issue #56: [SCM-739] Use shallow clones when cloning a git repo
Posted by olamy <gi...@git.apache.org>.
Github user olamy commented on the issue:
https://github.com/apache/maven-scm/pull/56
Good idea!! but the change is not backward compat so IMHO we need something configurable.
Default clone must a complete per default and we can add a new parameter for this (release plugin must be changed to use the new parameter)
WDYT?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-scm issue #56: [SCM-739] Use shallow clones when cloning a git repo
Posted by znerd <gi...@git.apache.org>.
Github user znerd commented on the issue:
https://github.com/apache/maven-scm/pull/56
@olamy Good point.
Suggested approach:
1. Introduce a configuration parameter now, e.g. `shallow` – and default to `false`. This may not require a major version bump.
2. On the next major version release of the plugin, default to `true` – and document this in the release notes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org