[GitHub] [pulsar] codelipenghui commented on a change in pull request #4372: Fix bug of Key_Shared Ordering

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #4372: Fix bug of Key_Shared Ordering
URL: https://github.com/apache/pulsar/pull/4372#discussion_r287600466
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
 ##########
 @@ -409,15 +410,14 @@ public synchronized void readEntriesComplete(List<Entry> entries, Object ctx) {
         }
 
         sendMessagesToConsumers(readType, entries);
-
-        readMoreEntries();
     }
 
     protected void sendMessagesToConsumers(ReadType readType, List<Entry> entries) {
         int start = 0;
         int entriesToDispatch = entries.size();
         long totalMessagesSent = 0;
         long totalBytesSent = 0;
+        AtomicInteger messagesToConsumer = new AtomicInteger(entries.size());
 
 Review comment:
   This change not to solve the problem of Key_Shared subscription, i initial think this will reduce the reading frequency of ledger in shared subscription.  This will wait for the message to be written to the consumers and then read again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services