You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2026/09/29 13:01:39 UTC
[S] Change in asterixdb[trinity]: [NO ISSUE][MISC] Record AI work with Generated-by
From Michael Blow <mb...@apache.org>:
Michael Blow has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21926?usp=email )
Change subject: [NO ISSUE][MISC] Record AI work with Generated-by
......................................................................
[NO ISSUE][MISC] Record AI work with Generated-by
- user model changes: no
- storage format changes: no
- interface changes: no
Details: CLAUDE.md here still asked for a Co-Authored-By trailer on
AI-assisted commits, while this repo records them with Generated-by, as
master's copy already says. Take master's Commit Messages section as it
stands, which also keeps Ext-ref inside the one trailer block.
Generated-by: Claude Opus 5.5 <no...@anthropic.com>
Change-Id: I4ab6ec785eac4a0dcd7f4d719855841654ddd906
---
M CLAUDE.md
1 file changed, 14 insertions(+), 11 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/26/21926/1
diff --git a/CLAUDE.md b/CLAUDE.md
index 9591e89..93bd780 100644
--- a/CLAUDE.md
+++ b/CLAUDE.md
@@ -74,24 +74,25 @@
## Commit Messages
-**Every commit message must end with the trailer:**
+**Every AI-assisted commit message must end with the trailer:**
```
-Co-Authored-By: Claude Opus 5 <no...@anthropic.com>
+Generated-by: Claude Opus 5 <no...@anthropic.com>
```
-(naming whichever model actually did the work). This has repeatedly been missed and caught only
-after the change was pushed for review, which costs a message-only patchset.
+(naming whichever model actually did the work). This repo records AI contributions with
+`Generated-by:`, **not** `Co-Authored-By:` — a downstream extension may use the other form in its
+own repository, but not here. This has repeatedly been missed and caught only after the change was
+pushed for review, which costs a message-only patchset.
**Write it at commit time, not as a follow-up amend.** The footer must be one contiguous run of
-trailers, with the `Co-Authored-By` line adjacent to `Change-Id`:
+trailers — `Ext-ref:` included, with no blank line anywhere inside it:
```
<body>
<- exactly one blank line
Ext-ref: <downstream-issue>
-
-Co-Authored-By: Claude Opus 5 <no...@anthropic.com>
+Generated-by: Claude Opus 5 <no...@anthropic.com>
Change-Id: I...
```
@@ -111,15 +112,17 @@
Two ways the footer gets destroyed, both of which make the `commit-msg` hook mint a **second**
`Change-Id` and silently orphan the change:
-- **A blank line between `Change-Id:` and `Co-Authored-By:`** splits the footer, so the last
- paragraph is read as body text.
+- **A blank line anywhere in the trailer block** — between `Ext-ref:` and `Generated-by:`, or
+ between `Generated-by:` and `Change-Id:` — splits the footer, so the last paragraph is read as
+ body text.
- **Ending the message with a non-trailer line** — most often
`(cherry picked from commit <sha>)` on a backport. Put that line in its own paragraph *above* the
trailer block so the message still ends with a trailer.
If the trailer must be added after the fact, rebuild the whole message rather than appending a line:
-capture the `Change-Id` first, strip every `Change-Id:`/`Co-Authored-By:` line, then re-append both
-contiguously. Verify before pushing — this must print exactly `1`, matching the original:
+capture the `Change-Id` first, strip every `Ext-ref:`/`Generated-by:`/`Change-Id:` line, then
+re-append them contiguously. Verify before pushing — this must print exactly `1`, matching the
+original:
```bash
git log -1 --format=%B | grep -c '^Change-Id:'
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21926?usp=email
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: asterixdb
Gerrit-Branch: trinity
Gerrit-Change-Id: I4ab6ec785eac4a0dcd7f4d719855841654ddd906
Gerrit-Change-Number: 21926
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>