You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2017/06/05 12:05:54 UTC
Review Request 59803: LENS-1432 : Map Join tuning broken for this
query leading to Map timeouts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59803/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1432
https://issues.apache.org/jira/browse/LENS-1432
Repository: lens
Description
-------
CubeQueryContext.getDimsToQuery() is empty, causing the problem.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/MultiCandidateQueryWriterContext.java d57c027
lens-cube/src/main/java/org/apache/lens/cube/parse/QueryWriterContext.java d55de1f
lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java caf8770
Diff: https://reviews.apache.org/r/59803/diff/1/
Testing
-------
Thanks,
Sushil Mohanty
Re: Review Request 59803: LENS-1432 : Map Join tuning broken for this
query leading to Map timeouts
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59803/#review176979
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java
Line 50 (original), 49 (patched)
<https://reviews.apache.org/r/59803/#comment250545>
Should we check !ctx.getQueryWriterContext().getDimsToQuery().isEmpty() and ctx.getQueryWriterContext().getDimsToQuery()!=null
- Puneet Gupta
On June 5, 2017, 2:18 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59803/
> -----------------------------------------------------------
>
> (Updated June 5, 2017, 2:18 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1432
> https://issues.apache.org/jira/browse/LENS-1432
>
>
> Repository: lens
>
>
> Description
> -------
>
> CubeQueryContext.getDimsToQuery() is empty, causing the problem.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/MultiCandidateQueryWriterContext.java d57c027
> lens-cube/src/main/java/org/apache/lens/cube/parse/QueryWriterContext.java d55de1f
> lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java caf8770
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 76ea77d
>
>
> Diff: https://reviews.apache.org/r/59803/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 59803: LENS-1432 : Map Join tuning broken for this
query leading to Map timeouts
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59803/#review176998
-----------------------------------------------------------
Ship it!
Ship It!
- Puneet Gupta
On June 6, 2017, 6:59 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59803/
> -----------------------------------------------------------
>
> (Updated June 6, 2017, 6:59 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1432
> https://issues.apache.org/jira/browse/LENS-1432
>
>
> Repository: lens
>
>
> Description
> -------
>
> CubeQueryContext.getDimsToQuery() is empty, causing the problem.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/MultiCandidateQueryWriterContext.java d57c027
> lens-cube/src/main/java/org/apache/lens/cube/parse/QueryWriterContext.java d55de1f
> lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java caf8770
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 76ea77d
>
>
> Diff: https://reviews.apache.org/r/59803/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 59803: LENS-1432 : Map Join tuning broken for this
query leading to Map timeouts
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59803/
-----------------------------------------------------------
(Updated June 6, 2017, 6:59 a.m.)
Review request for lens.
Changes
-------
- Addressed review.
Bugs: LENS-1432
https://issues.apache.org/jira/browse/LENS-1432
Repository: lens
Description
-------
CubeQueryContext.getDimsToQuery() is empty, causing the problem.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/MultiCandidateQueryWriterContext.java d57c027
lens-cube/src/main/java/org/apache/lens/cube/parse/QueryWriterContext.java d55de1f
lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java caf8770
lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 76ea77d
Diff: https://reviews.apache.org/r/59803/diff/3/
Changes: https://reviews.apache.org/r/59803/diff/2-3/
Testing
-------
Thanks,
Sushil Mohanty
Re: Review Request 59803: LENS-1432 : Map Join tuning broken for this
query leading to Map timeouts
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59803/
-----------------------------------------------------------
(Updated June 5, 2017, 2:18 p.m.)
Review request for lens.
Changes
-------
- Added assert
Bugs: LENS-1432
https://issues.apache.org/jira/browse/LENS-1432
Repository: lens
Description
-------
CubeQueryContext.getDimsToQuery() is empty, causing the problem.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/MultiCandidateQueryWriterContext.java d57c027
lens-cube/src/main/java/org/apache/lens/cube/parse/QueryWriterContext.java d55de1f
lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java caf8770
lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 76ea77d
Diff: https://reviews.apache.org/r/59803/diff/2/
Changes: https://reviews.apache.org/r/59803/diff/1-2/
Testing
-------
Thanks,
Sushil Mohanty