[GitHub] [hbase] comnetwork commented on pull request #3604: HBASE-26210 HBase Write should be doomed to hang when cell size excee…

[GitBox <gi...@apache.org>]

comnetwork commented on pull request #3604:
URL: https://github.com/apache/hbase/pull/3604#issuecomment-902393254


   @Apache9 ,  My PR not skip adding the size，it still add the size before really adding the cell to `currActive `, but it  just change checking size logic in `CompactingMemStore.shouldFlushInMemory` a little to make it  similar to normal `DefaultMemStore `flushing to disk : it not make sure the size of `currActive`  less than `inmemoryFlushSize` strictly any more, instead,  it can tolerate the size of `currActive` to just cross the `inmemoryFlushSize `boundary by at most one cell. After we adding cell size to the size of the `currActive ` and find its size exceeds  `inmemoryFlushSize` , we flush the {{currActive}} in memory,


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org