[GitHub] [hive] mbathori-cloudera commented on pull request #2919: HIVE-25667: Unify code managing JDBC databases in tests

[GitBox <gi...@apache.org>]

mbathori-cloudera commented on pull request #2919:
URL: https://github.com/apache/hive/pull/2919#issuecomment-1013944369


   @zabetak Thanks for reviewing my changes. I made a new commit where I tried to address all of your comments.
   - I moved the common database classes to the `hive-testutils` module.
   - Moved metastore related parts from common database classes to a wrapper class in the metastore.
   - Removed the `ExternalResource` and refactored depending functions.
   
   
   **_Some note for the hive-testutil pom changes:_**
   I had a strange issue while adding `hive-testutils` to the `itests/util/pom.xml`. The qtests were not executed and the build automatically skipped all of them without any error message. It turned out that a dependency called `junit-jupiter-api` caused this issue. If I set this dependency to test scope the problem would be solved but I can’t do it because classes that are using it are placed in the src package. The easiest solution was to set the dependency to _optional_ so it will be excluded.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org