You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/16 15:10:36 UTC

[GitHub] [beam] steveniemitz commented on a diff in pull request #22718: Support custom avro DatumReader when reading from BigQuery #22717

steveniemitz commented on code in PR #22718:
URL: https://github.com/apache/beam/pull/22718#discussion_r946904496


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java:
##########
@@ -804,6 +827,10 @@ public enum Method {
 
       abstract Builder<T> setParseFn(SerializableFunction<SchemaAndRecord, T> parseFn);
 
+      abstract Builder<T> setReaderDatumFactory(AvroSource.DatumReaderFactory<T> factory);

Review Comment:
   this should be named `setDatumReaderFactory` no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org