You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-commits@db.apache.org by kr...@apache.org on 2012/05/30 00:09:26 UTC
svn commit: r1344027 - in /db/derby/code/branches/10.9: ./
java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java
Author: kristwaa
Date: Tue May 29 22:09:25 2012
New Revision: 1344027
URL: http://svn.apache.org/viewvc?rev=1344027&view=rev
Log:
DERBY-5789: Improve istat log message when dropping disposable statistics
Merged fix from trunk (r1343667).
Modified:
db/derby/code/branches/10.9/ (props changed)
db/derby/code/branches/10.9/java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java
Propchange: db/derby/code/branches/10.9/
------------------------------------------------------------------------------
Merged /db/derby/code/trunk:r1343667
Modified: db/derby/code/branches/10.9/java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java
URL: http://svn.apache.org/viewvc/db/derby/code/branches/10.9/java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java?rev=1344027&r1=1344026&r2=1344027&view=diff
==============================================================================
--- db/derby/code/branches/10.9/java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java (original)
+++ db/derby/code/branches/10.9/java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java Tue May 29 22:09:25 2012
@@ -479,7 +479,7 @@ public class IndexStatisticsDaemonImpl
// For now we know that disposable stats only exist in two cases,
// and that we'll only get one match for both of them per table:
// a) orphaned statistics entries (i.e. DERBY-5681)
- // b) single-column primary keys (TODO: after DERBY-3790 is done)
+ // b) single-column primary keys
for (int si=0; si < stats.length; si++) {
UUID referencedIndex = stats[si].getReferenceID();
boolean isValid = false;
@@ -498,10 +498,11 @@ public class IndexStatisticsDaemonImpl
// mechanism in case of another bug like DERBY-5681 in Derby.
if (!isValid) {
String msg = "dropping disposable statistics entry " +
- stats[si].getUUID() + " for table " +
- stats[si].getTableUUID();
+ stats[si].getUUID() + " for index " +
+ stats[si].getReferenceID() + " (cols=" +
+ stats[si].getColumnCount() + ")";
logAlways(td, null, msg);
- trace(1, msg);
+ trace(1, msg + " on table " + stats[si].getTableUUID());
DataDictionary dd = lcc.getDataDictionary();
if (!lcc.dataDictionaryInWriteMode()) {
dd.startWriting(lcc);