You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "tdiesler (via GitHub)" <gi...@apache.org> on 2024/03/27 11:07:19 UTC
[PR] -- investigate GHA failure with -Djib.from.platforms=linux/amd64,linu… [camel-k]
tdiesler opened a new pull request, #5293:
URL: https://github.com/apache/camel-k/pull/5293
…x/arm64
Don't merge. This is to investigate a possible GHA issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] -- investigate GHA failure with -Djib.from.platforms=linux/amd64,linu… [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #5293:
URL: https://github.com/apache/camel-k/pull/5293#discussion_r1549070972
##########
pkg/builder/jib.go:
##########
@@ -114,6 +114,8 @@ func (t *jibTask) Do(ctx context.Context) v1.BuildStatus {
if t.task.Configuration.ImagePlatforms != nil {
platforms := strings.Join(t.task.Configuration.ImagePlatforms, ",")
mavenArgs = append(mavenArgs, jib.JibMavenFromPlatforms+platforms)
+ } else {
+ mavenArgs = append(mavenArgs, jib.JibMavenFromPlatforms+"linux/amd64,linux/arm64")
Review Comment:
This is most likely going to break the upgrade check, as it happened in https://github.com/apache/camel-k/pull/5246#issuecomment-2009270960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] -- investigate GHA failure with -Djib.from.platforms=linux/amd64,linu… [camel-k]
Posted by "tdiesler (via GitHub)" <gi...@apache.org>.
tdiesler closed pull request #5293: -- investigate GHA failure with -Djib.from.platforms=linux/amd64,linu…
URL: https://github.com/apache/camel-k/pull/5293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] -- investigate GHA failure with -Djib.from.platforms=linux/amd64,linu… [camel-k]
Posted by "tdiesler (via GitHub)" <gi...@apache.org>.
tdiesler commented on PR #5293:
URL: https://github.com/apache/camel-k/pull/5293#issuecomment-2047030944
Can we please run this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org