You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@gump.apache.org by Sam Ruby <ru...@apache.org> on 2003/03/28 18:50:17 UTC

Re: [GUMP] Build Failure - excalibur-fortress-examples

Berin Loritsch wrote:
> 
> How do we get gump to complain when a variable is not valid?

Either convince Ant to fail the build or add an explicit regex for this 
condition.  I'd recommend the former.

> Excalibur-Monitor was failing because it depended on Component,
> which was marked success even though it failed looking for
> the "${tools.dir}/lib" and "${tools.dir}/ext" directories.
> Monitor couldn't get the testcase jar so it failed.

Any Ant developers out there have a suggestion on how to get the 
following to fail instead of simply printing a warning:

http://cvs.apache.org/builds/gump/2003-03-28/excalibur-component.html

> Hopefully it will all wash out in the end (I think I fixed it),
> but failing silently is not helping.

Agreed.

- Sam Ruby




Re: Build Failure - excalibur-fortress-examples

Posted by Leo Simons <le...@apache.org>.
Sam Ruby wrote:
>> Excalibur-Monitor was failing because it depended on Component,
>> which was marked success even though it failed looking for
>> the "${tools.dir}/lib" and "${tools.dir}/ext" directories.
>> Monitor couldn't get the testcase jar so it failed.

actually, nope (I think).

---
jar-testcase: [mkdir] Created dir: 
/home/rubys/jakarta/avalon-excalibur/component/build/lib [jar] Building 
jar: 
/home/rubys/jakarta/avalon-excalibur/component/build/lib/excalibur-testcase-20030328.jar
---

the jar was built, but not listed as being exported by 
excalibur-component. I've updated the definition today to mention it 
builds the jar. I also updated monitor so that the build/testclasses are 
added to the path made available to junit. See commits earlier today. 
Think it should work, but haven't had time to test.

> Any Ant developers out there have a suggestion on how to get the 
> following to fail instead of simply printing a warning?

<project>

<target name="check-valid-properties">
     <available dir="${lib.dir}" property="lib.dir.present"/>
     <fail unless="lib.dir.present" message="Invalid property setup: the 
lib.dir property is improperly set to ${lib.dir}!"/>
     <available dir="${tools.dir}" property="tools.dir.present"/>
     <fail unless="tools.dir.present" message="Invalid property setup: 
the lib.dir property is improperly set to ${tools.dir}!"/>
</target>

<target name="main" depends="check-valid-properties/>

</project>

in the case of excalibur, we no longer actually need the referenced 
directories (look at 'em; they;re empty).

>> Hopefully it will all wash out in the end (I think I fixed it),
>> but failing silently is not helping.
> 
> Agreed.

yep. There's a lot of room for improvement.

cheers!

- LSD



Re: [GUMP] Build Failure - excalibur-fortress-examples

Posted by Stefan Bodewig <bo...@apache.org>.
On Fri, 28 Mar 2003, Sam Ruby <ru...@apache.org> wrote:

> Any Ant developers out there have a suggestion on how to get the
> following to fail instead of simply printing a warning:
> 
> http://cvs.apache.org/builds/gump/2003-03-28/excalibur-component.html

Oh, it failed about eight months back and we've "fixed"[1] it to just
print a warning as some Avalon builds failed in Gump[2] 8-)

The issue is that the build file defines a path but never uses it, so
it doesn't do any harm.  If the build file tried to use the path
later, the build would fail.

Stefan

Footnotes: 
[1] <http://cvs.apache.org/viewcvs/ant/src/main/org/apache/tools/ant/Project.java.diff?r1=1.111&r2=1.112>

[2] <http://archives.apache.org/eyebrowse/ReadMsg?listName=dev@avalon.apache.org&msgNo=12243>