[jira] [Commented] (HIVE-5756) Implement vectorization support for IF conditional expression for long, double, timestamp and boolean inputs

["Jitendra Nath Pandey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13839475#comment-13839475 ] 

Jitendra Nath Pandey commented on HIVE-5756:
--------------------------------------------

The patch looks good, a few issues:
# IfExprColumnColumn.txt assumes that the types of the last two expressions are same which may not be true. The IF statement in hive allows different datatypes for the if-part vs else-part.
# 'copySelected' method in LongColumnVector and DoubleColumnVector : The 'isRepeating' is always being set to false in the output even if input has it repeating.
# 'fill' method: If same value is being filled and selectedInUse is false, should we set isRepeating flag to true?
# Vectorizer.java has only indentation changes? I am fine with that but just wanted to confirm so that we don't miss something.

> Implement vectorization support for IF conditional expression for long, double, timestamp and boolean inputs
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-5756
>                 URL: https://issues.apache.org/jira/browse/HIVE-5756
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Eric Hanson
>            Assignee: Eric Hanson
>         Attachments: HIVE-5756.1.patch, HIVE-5756.2.patch, HIVE-5756.3.patch, HIVE-5756.4.patch, HIVE-5756.5.patch
>
>
> Implement full, end-to-end support for IF in vectorized mode, including new VectorExpression class(es), VectorizationContext translation to a VectorExpression, and unit tests for these, as well as end-to-end ad hoc testing. An end-to-end .q test is recommended but optional.
> This is high priority because IF is the most popular conditional expression.



--
This message was sent by Atlassian JIRA
(v6.1#6144)