You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/05/03 20:51:11 UTC
[GitHub] [phoenix] gokceni commented on a change in pull request #1216: PHOENIX-6457 - Optionally store schema version string in SYSTEM.CATALOG
gokceni commented on a change in pull request #1216:
URL: https://github.com/apache/phoenix/pull/1216#discussion_r625359317
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataProtocol.java
##########
@@ -95,7 +95,7 @@
public static final long MIN_SYSTEM_TABLE_TIMESTAMP_4_14_0 = MIN_TABLE_TIMESTAMP + 28;
public static final long MIN_SYSTEM_TABLE_TIMESTAMP_4_15_0 = MIN_TABLE_TIMESTAMP + 29;
public static final long MIN_SYSTEM_TABLE_TIMESTAMP_4_16_0 = MIN_TABLE_TIMESTAMP + 33;
- public static final long MIN_SYSTEM_TABLE_TIMESTAMP_4_17_0 = MIN_TABLE_TIMESTAMP + 34;
+ public static final long MIN_SYSTEM_TABLE_TIMESTAMP_4_17_0 = MIN_TABLE_TIMESTAMP + 35;
Review comment:
How do we come up with 35?
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/CreateTableIT.java
##########
@@ -1166,6 +1166,31 @@ public void testTableDescriptorPriority() throws SQLException, IOException {
}
}
+ @Test
+ public void testCreateTableSchemaVersion() throws Exception {
+ Properties props = new Properties();
+ final String schemaName = generateUniqueName();
+ final String tableName = generateUniqueName();
+ final String version = "V1.0";
+ try (Connection conn = DriverManager.getConnection(getUrl(), props)) {
+ testCreateTableSchemaVersionHelper(conn, schemaName, tableName, version);
+ }
+ }
+
+ public static void testCreateTableSchemaVersionHelper(Connection conn, String schemaName, String tableName,
+ String dataTableVersion)
+ throws Exception {
+ final String dataTableFullName = SchemaUtil.getTableName(schemaName, tableName);
+ String ddl =
+ "CREATE TABLE " + dataTableFullName + " (\n" + "ID1 VARCHAR(15) NOT NULL,\n"
Review comment:
If I support changing Storage format or Column encoding, we will need to do alter table set schema again right? I think it will be good to invest in plumbing this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org