You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by Davanum Srinivas <da...@gmail.com> on 2004/10/15 00:52:09 UTC
Re: cvs commit: ws-axis/java/src/org/apache/axis/transport/http A xisServlet.java
ok then.
-- dims
On Thu, 14 Oct 2004 18:46:40 -0400, Tom Jordahl <to...@macromedia.com> wrote:
>
> Look, the change to AxisServet is harmless. I don't care about the Session
> stuff, but the servlet is core to the operation of Axis.
>
> How about we leave the workaround in the servlet, but not (as I didn't)
> remove any servlet 2.3 apis from other classes.
>
> My product has to support servlet 2.2 because we support WebSphere 4 and
> WebLogic 6. If we drop support then I will be more than happy to change it
> back but right now I need it.
>
> --
> Tom Jordahl
> Macromedia Server Development
>
> > -----Original Message-----
> > From: Davanum Srinivas [mailto:davanum@gmail.com]
> > Sent: Thursday, October 14, 2004 6:06 PM
> > To: Glen Daniels
> > Cc: tomj@apache.org; ws-axis-cvs@apache.org
> > Subject: Re: cvs commit: ws-axis/java/src/org/apache/axis/transport/http
> > AxisServlet.java
> >
> > I agree with Glen.
> >
> > -- dims
> >
> >
> > On Thu, 14 Oct 2004 14:58:13 -0700, Glen Daniels <gl...@thoughtcraft.com>
> > wrote:
> > >
> > > -1, I think....
> > >
> > > We decided to move to Servlet 2.3 last year. It was VOTEd on and passed
> > > (and you voted for it!). AxisHttpSessionListener depends on 2.3.
> > >
> > > --Glen
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: tomj@apache.org [mailto:tomj@apache.org]
> > > > Sent: Thursday, October 14, 2004 2:11 PM
> > > > To: ws-axis-cvs@apache.org
> > > > Subject: cvs commit:
> > > > ws-axis/java/src/org/apache/axis/transport/http AxisServlet.java
> > > >
> > > > tomj 2004/10/14 14:10:51
> > > >
> > > > Modified: java/src/org/apache/axis/transport/http
> > > > AxisServlet.java
> > > > Log:
> > > > Fix bug 1594
> > > > http://nagoya.apache.org/jira/browse/AXIS-1594
> > > >
> > > > Support Servlet 2.2 API by not calling
> > > > HttpServletRequest.getRequestURL()
> > > > This is important for the WebSphere 4 app server.
> > > >
> > > > Revision Changes Path
> > > > 1.181 +8 -5
> > > > ws-axis/java/src/org/apache/axis/transport/http/AxisServlet.java
> > > >
> > > > Index: AxisServlet.java
> > > > ===================================================================
> > > > RCS file:
> > > > /home/cvs/ws-axis/java/src/org/apache/axis/transport/http/Axis
> > > > Servlet.java,v
> > > > retrieving revision 1.180
> > > > retrieving revision 1.181
> > > > diff -u -r1.180 -r1.181
> > > > --- AxisServlet.java 9 Oct 2004 03:50:19 -0000 1.180
> > > > +++ AxisServlet.java 14 Oct 2004 21:10:51 -0000 1.181
> > > > @@ -30,6 +30,7 @@
> > > > import javax.servlet.ServletException;
> > > > import javax.servlet.http.HttpServletRequest;
> > > > import javax.servlet.http.HttpServletResponse;
> > > > +import javax.servlet.http.HttpUtils;
> > > > import javax.xml.soap.MimeHeader;
> > > > import javax.xml.soap.MimeHeaders;
> > > > import javax.xml.soap.SOAPException;
> > > > @@ -147,7 +148,6 @@
> > > >
> > > > isDebug= log.isDebugEnabled();
> > > > if(isDebug) log.debug("In servlet init");
> > > > -
> > > > transportName = getOption(context,
> > > > INIT_PROPERTY_TRANSPORT_NAME,
> > > >
> > > > HTTPTransport.DEFAULT_TRANSPORT_NAME);
> > > > @@ -247,8 +247,11 @@
> > > > // req.getRequestURL returns "localhost"
> > > > in the remote
> > > > // scenario rather than the actual host name.
> > > > //
> > > > - // ? Still true? For which JVM's?
> > > > - String url = request.getRequestURL().toString();
> > > > + // But more importantly, getRequestURL()
> > > > is a servlet 2.3
> > > > + // API and to support servlet 2.2 (aka WebSphere 4)
> > > > + // we need to leave this in for a while
> > > > longer. tomj 10/14/2004
> > > > + //
> > > > + String url =
> > > > HttpUtils.getRequestURL(request).toString();
> > > >
> > > >
> > > > msgContext.setProperty(MessageContext.TRANS_URL, url);
> > > >
> > > > @@ -596,7 +599,7 @@
> > > > /* Set the request(incoming) message field in
> > > > the context */
> > > >
> > > > /**********************************************************/
> > > > msgContext.setRequestMessage(requestMsg);
> > > > - String url = req.getRequestURL().toString();
> > > > + String url = HttpUtils.getRequestURL(req).toString();
> > > > msgContext.setProperty(MessageContext.TRANS_URL, url);
> > > > // put character encoding of request to message context
> > > > // in order to reuse it during the whole process.
> > > > @@ -1100,7 +1103,7 @@
> > > > Class plugin = Class.forName
> > > > ((String) this.transport.getOption (queryHandler));
> > > > Method pluginMethod =
> > > > plugin.getDeclaredMethod ("invoke",
> > > > new Class[] {
> > > > msgContext.getClass() });
> > > > - String url =
> > > > request.getRequestURL().toString();
> > > > + String url =
> > > > HttpUtils.getRequestURL(request).toString();
> > > >
> > > > // Place various useful
> > > > servlet-related objects in
> > > > // the MessageContext object
> > > > being delivered to the
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> >
> >
> > --
> > Davanum Srinivas - http://webservices.apache.org/~dims/
>
--
Davanum Srinivas - http://webservices.apache.org/~dims/