You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/11/04 20:47:41 UTC
[GitHub] [helix] junkaixue commented on a change in pull request #1899: add take/free instance(s) API
junkaixue commented on a change in pull request #1899:
URL: https://github.com/apache/helix/pull/1899#discussion_r743190217
##########
File path: helix-rest/src/main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementInstanceInfo.java
##########
@@ -0,0 +1,68 @@
+package org.apache.helix.rest.clusterMaintenanceService;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayList;
+import java.util.List;
+
+
+public class MaintenanceManagementInstanceInfo {
+
+ public enum Status {
+ SUCCESS,
+ FAILURE
+ }
+ private List<Object> operationResult;
Review comment:
Shall we make it as a map for searching purpose? Or just one String. Not quite sure about the list of string.
##########
File path: helix-rest/src/main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementInstanceInfo.java
##########
@@ -0,0 +1,68 @@
+package org.apache.helix.rest.clusterMaintenanceService;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayList;
+import java.util.List;
+
+
+public class MaintenanceManagementInstanceInfo {
+
+ public enum Status {
Review comment:
Let's make it more detailed naming? OperationalStatus?
##########
File path: helix-rest/src/main/java/org/apache/helix/rest/common/datamodel/RestSnapShot.java
##########
@@ -0,0 +1,13 @@
+package org.apache.helix.rest.common.datamodel;
+
+
+public class RestSnapShot {
Review comment:
Add a comment at class level that this Snapshot can extend Snapshot from common/core module if there is more generic snapshot.
##########
File path: helix-rest/src/main/java/org/apache/helix/rest/common/datamodel/RestSnapShot.java
##########
@@ -0,0 +1,13 @@
+package org.apache.helix.rest.common.datamodel;
+
+
+public class RestSnapShot {
Review comment:
Have a kv map there at least? And simple kv set/get methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org