You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "aljazerzen (via GitHub)" <gi...@apache.org> on 2024/01/04 13:30:42 UTC
[I] Export CMake config [arrow-nanoarrow]
aljazerzen opened a new issue, #350:
URL: https://github.com/apache/arrow-nanoarrow/issues/350
When trying to use this library from another CMake project, I've noticed that this project does not export CMake config.
I know that this library is meant to be vendored/bundled with my project, but in my case, this is quite undesirable.
So I've created a patch to export the config here: https://github.com/aljazerzen/arrow-nanoarrow-nix/blob/main/0001-patch.patch
I'm relatively new to CMake, so this issue is mostly about "i this a good idea" and "why not?"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Export CMake config [arrow-nanoarrow]
Posted by "aljazerzen (via GitHub)" <gi...@apache.org>.
aljazerzen commented on issue #350:
URL: https://github.com/apache/arrow-nanoarrow/issues/350#issuecomment-1879031363
I can open the PR, I thought there was a reason this was not done in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Export CMake config [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on issue #350:
URL: https://github.com/apache/arrow-nanoarrow/issues/350#issuecomment-1877363216
I have definitely seen this in other projects...for the few projects I've seen so far it I've used FetchContent but I have a very specific set of things I've worked on and don't have a lot of experience with general CMake usage.
@assignUser does this seem like a reasonable thing to add to nanoarrow's CMake configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Export CMake config [arrow-nanoarrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #350:
URL: https://github.com/apache/arrow-nanoarrow/issues/350#issuecomment-1878106898
Yes, exporting a `nanoarrowConfig.cmake` is the 'modern CMake' way to make you lib usable by other projects. I can have a look at the patch/turn it into a pr (feel free to that as well @aljazerzen!) but I'll have to read up on the details a bit. As a victim of bad configs I want to make it right :D (e.g. always including targets is bad when using fetchContent because the targets then already exist and clash).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Export CMake config [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot closed issue #350: Export CMake config
URL: https://github.com/apache/arrow-nanoarrow/issues/350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org