You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2011/03/06 15:49:25 UTC

[jira] Created: (DERBY-5092) [patch] avoid Boolean allocations for rowset data in client cursor

[patch] avoid Boolean allocations for rowset data in client cursor
------------------------------------------------------------------

                 Key: DERBY-5092
                 URL: https://issues.apache.org/jira/browse/DERBY-5092
             Project: Derby
          Issue Type: Improvement
          Components: Network Client
    Affects Versions: 10.7.1.1
            Reporter: Dave Brosius
            Priority: Trivial
             Fix For: 10.8.0.0
         Attachments: avoid_boolean_allocs.diff

code allocates a new Boolean for every row value of a boolean column, creating needless garbage. Patch switches to use immutable Boolean.TRUE and Boolean.FALSE values.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (DERBY-5092) [patch] avoid Boolean allocations for rowset data in client cursor

Posted by "Lily Wei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lily Wei resolved DERBY-5092.
-----------------------------

    Resolution: Fixed

> [patch] avoid Boolean allocations for rowset data in client cursor
> ------------------------------------------------------------------
>
>                 Key: DERBY-5092
>                 URL: https://issues.apache.org/jira/browse/DERBY-5092
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>    Affects Versions: 10.7.1.1
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>              Labels: derby_triage10_8
>             Fix For: 10.8.0.0
>
>         Attachments: avoid_boolean_allocs.diff
>
>
> code allocates a new Boolean for every row value of a boolean column, creating needless garbage. Patch switches to use immutable Boolean.TRUE and Boolean.FALSE values.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (DERBY-5092) [patch] avoid Boolean allocations for rowset data in client cursor

Posted by "Lily Wei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lily Wei updated DERBY-5092:
----------------------------

    Issue & fix info: [Patch Available]
            Assignee: Dave Brosius
              Labels: derby_triage10_8  (was: )

I've committed with revision 1083493. Thanks, Dave.

> [patch] avoid Boolean allocations for rowset data in client cursor
> ------------------------------------------------------------------
>
>                 Key: DERBY-5092
>                 URL: https://issues.apache.org/jira/browse/DERBY-5092
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>    Affects Versions: 10.7.1.1
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>              Labels: derby_triage10_8
>             Fix For: 10.8.0.0
>
>         Attachments: avoid_boolean_allocs.diff
>
>
> code allocates a new Boolean for every row value of a boolean column, creating needless garbage. Patch switches to use immutable Boolean.TRUE and Boolean.FALSE values.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (DERBY-5092) [patch] avoid Boolean allocations for rowset data in client cursor

Posted by "Lily Wei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lily Wei updated DERBY-5092:
----------------------------

    Comment: was deleted

(was: I've committed with revision 1083493. Thanks, Dave.)

> [patch] avoid Boolean allocations for rowset data in client cursor
> ------------------------------------------------------------------
>
>                 Key: DERBY-5092
>                 URL: https://issues.apache.org/jira/browse/DERBY-5092
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>    Affects Versions: 10.7.1.1
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>              Labels: derby_triage10_8
>             Fix For: 10.8.0.0
>
>         Attachments: avoid_boolean_allocs.diff
>
>
> code allocates a new Boolean for every row value of a boolean column, creating needless garbage. Patch switches to use immutable Boolean.TRUE and Boolean.FALSE values.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (DERBY-5092) [patch] avoid Boolean allocations for rowset data in client cursor

Posted by "Lily Wei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lily Wei resolved DERBY-5092.
-----------------------------

    Resolution: Fixed

I've committed with revision 1083603. Thanks, Dave.

> [patch] avoid Boolean allocations for rowset data in client cursor
> ------------------------------------------------------------------
>
>                 Key: DERBY-5092
>                 URL: https://issues.apache.org/jira/browse/DERBY-5092
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>    Affects Versions: 10.7.1.1
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>              Labels: derby_triage10_8
>             Fix For: 10.8.0.0
>
>         Attachments: avoid_boolean_allocs.diff
>
>
> code allocates a new Boolean for every row value of a boolean column, creating needless garbage. Patch switches to use immutable Boolean.TRUE and Boolean.FALSE values.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (DERBY-5092) [patch] avoid Boolean allocations for rowset data in client cursor

Posted by "Lily Wei (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008876#comment-13008876 ] 

Lily Wei commented on DERBY-5092:
---------------------------------

Suites.all and derbyall run clean with this patch. If there is no objection, I will commit this patch soon.

> [patch] avoid Boolean allocations for rowset data in client cursor
> ------------------------------------------------------------------
>
>                 Key: DERBY-5092
>                 URL: https://issues.apache.org/jira/browse/DERBY-5092
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>    Affects Versions: 10.7.1.1
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: 10.8.0.0
>
>         Attachments: avoid_boolean_allocs.diff
>
>
> code allocates a new Boolean for every row value of a boolean column, creating needless garbage. Patch switches to use immutable Boolean.TRUE and Boolean.FALSE values.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Reopened: (DERBY-5092) [patch] avoid Boolean allocations for rowset data in client cursor

Posted by "Lily Wei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lily Wei reopened DERBY-5092:
-----------------------------


I made a mistake. I should not check-in 1083493. I will back out the file. Thanks!

> [patch] avoid Boolean allocations for rowset data in client cursor
> ------------------------------------------------------------------
>
>                 Key: DERBY-5092
>                 URL: https://issues.apache.org/jira/browse/DERBY-5092
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>    Affects Versions: 10.7.1.1
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>              Labels: derby_triage10_8
>             Fix For: 10.8.0.0
>
>         Attachments: avoid_boolean_allocs.diff
>
>
> code allocates a new Boolean for every row value of a boolean column, creating needless garbage. Patch switches to use immutable Boolean.TRUE and Boolean.FALSE values.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira