[jira] [Comment Edited] (OAK-8448) VersionGC may get stuck at 60s scope

["Julian Reschke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881193#comment-16881193 ] 

Julian Reschke edited comment on OAK-8448 at 8/17/19 9:08 AM:
--------------------------------------------------------------

trunk: (1.16.0) [r1862806|http://svn.apache.org/r1862806] [r1862537|http://svn.apache.org/r1862537]
1.10: (1.10.4) [r1863942|http://svn.apache.org/r1863942]
1.8: [r1865342|http://svn.apache.org/r1865342]



was (Author: reschke):
trunk: (1.16.0) [r1862806|http://svn.apache.org/r1862806] [r1862537|http://svn.apache.org/r1862537]
1.10: [r1863942|http://svn.apache.org/r1863942]


> VersionGC may get stuck at 60s scope 
> -------------------------------------
>
>                 Key: OAK-8448
>                 URL: https://issues.apache.org/jira/browse/OAK-8448
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: documentmk
>    Affects Versions: 1.8.9
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Major
>             Fix For: 1.16.0, 1.10.4, 1.8.16
>
>         Attachments: OAK-8448.diff, test.diff
>
>
> It seems that if the VersionGarbageCollector reduces the scope to a 60s interval, it'll never change it back to a bigger interval. This is because the collectLimit gets set to 0:
> {noformat}
>             if (scope.getDurationMs() <= options.precisionMs) {
>                 // If we have narrowed the collect time interval down as much as we can, no
>                 // longer enforce a limit. We need to get through this.
>                 collectLimit = 0;
>                 log.debug("time interval <= precision ({} ms), disabling collection limits", options.precisionMs);
>             }
> {noformat}
> ...and later on this is interpreted as "there were no restrictions in the prior run that need to be updated":
> {noformat}
>                 if (maxCollect <= 0) {
>                     log.debug("successful run without effective limit, keeping recommendations");
>                 }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)