You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/11/28 06:07:09 UTC
[GitHub] [solr] dsmiley opened a new pull request, #1197: Refactor: remove unused "filter" in QueryCommand & getProcessedFilter
dsmiley opened a new pull request, #1197:
URL: https://github.com/apache/solr/pull/1197
1. QueryCommand: remove unused "filter"
2. SolrIndexSearcher.getProcessedFilter: remove unused setFilter param
Background:
While looking at SolrIndexSearcher.getProcessedFilter (on multiple occassions), it seemed to me the setFilter param was needless because a caller could simply provide the DocSet as a Query via DocSet.makeQuery (new in Solr 9). Then I realized that nobody actually passes setFilter any way so I simply removed it, leading me to remove QueryCommand.filter in-kind. Maybe it was used a long time ago; this is old code.
Not sure this needs a JIRA; it's a refactoring. I'm thinking of only doing this in Solr 10 for back-compat sake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #1197: Refactor: remove unused "filter" in QueryCommand & getProcessedFilter
Posted by GitBox <gi...@apache.org>.
dsmiley commented on PR #1197:
URL: https://github.com/apache/solr/pull/1197#issuecomment-1331009860
I think this PR is ready except fixing conflicts & adding a CHANGES.txt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley merged pull request #1197: Refactor: remove unused "filter" in QueryCommand & getProcessedFilter
Posted by GitBox <gi...@apache.org>.
dsmiley merged PR #1197:
URL: https://github.com/apache/solr/pull/1197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org