You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/26 11:51:24 UTC

[GitHub] [incubator-doris-manager] wangbokun opened a new pull request, #56: Change manager server getServerAddr to configure STUDIO_IP

wangbokun opened a new pull request, #56:
URL: https://github.com/apache/incubator-doris-manager/pull/56

   # Proposed changes
   
   ## Problem Summary:
   
   When the server has multiple IP addresses, the server sends a startup command to the client, and the server address is invalid,Configure the manager IP directly into the manger configure.
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris-manager] JNSimba commented on a diff in pull request #56: Change manager server getServerAddr to configure STUDIO_IP

Posted by GitBox <gi...@apache.org>.
JNSimba commented on code in PR #56:
URL: https://github.com/apache/incubator-doris-manager/pull/56#discussion_r861592074


##########
.gitignore:
##########
@@ -5,3 +5,21 @@ flink-doris-connector/target/
 spark-doris-connector/dependency-reduced-pom.xml
 spark-doris-connector/output/
 spark-doris-connector/target/
+manager/dm-agent/dm-agent.iml
+manager/dm-agent/target/
+manager/dm-common/dm-common.iml
+manager/dm-common/target/
+manager/dm-server/dm-server.iml
+manager/dm-server/target/
+manager/doris-manager.iml
+manager/general/general.iml
+manager/manager-server/manager-server.iml
+manager/manager-server/src/main/resources/web-resource/
+manager/manager-server/target/
+manager/manager/manager.iml
+manager/manager/target/
+manager/resource-common/resource-common.iml
+manager/resource-common/target/
+manager/general/target/

Review Comment:
   `manager/**/target`
   `manager/**/*.iml`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris-manager] wangbokun commented on pull request #56: Change manager server getServerAddr to configure STUDIO_IP

Posted by GitBox <gi...@apache.org>.
wangbokun commented on PR #56:
URL: https://github.com/apache/incubator-doris-manager/pull/56#issuecomment-1112148744

   choose configure write fixed STUDIO_IP or automatically ip address


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris-manager] JNSimba merged pull request #56: Change manager server getServerAddr to configure STUDIO_IP

Posted by GitBox <gi...@apache.org>.
JNSimba merged PR #56:
URL: https://github.com/apache/incubator-doris-manager/pull/56


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris-manager] JNSimba commented on a diff in pull request #56: Change manager server getServerAddr to configure STUDIO_IP

Posted by GitBox <gi...@apache.org>.
JNSimba commented on code in PR #56:
URL: https://github.com/apache/incubator-doris-manager/pull/56#discussion_r859582071


##########
manager/dm-server/src/main/java/org/apache/doris/stack/control/manager/ResourceNodeAndAgentManager.java:
##########
@@ -465,12 +462,7 @@ private boolean checkEventBeCancelled(long eventId) {
      * get server address
      */
     private String getServerAddr() {
-        String host = null;
-        try {
-            host = InetAddress.getLocalHost().getHostAddress();
-        } catch (UnknownHostException e) {
-            throw new ServerException("get server ip fail");
-        }
+        String host = System.getenv(EnvironmentDefine.STUDIO_IP_ENV);

Review Comment:
   It is recommended that STUDIO_IP is optional, keep the previous logic, and replace when STUDIO_IP is not empty



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris-manager] JNSimba commented on a diff in pull request #56: Change manager server getServerAddr to configure STUDIO_IP

Posted by GitBox <gi...@apache.org>.
JNSimba commented on code in PR #56:
URL: https://github.com/apache/incubator-doris-manager/pull/56#discussion_r861592074


##########
.gitignore:
##########
@@ -5,3 +5,21 @@ flink-doris-connector/target/
 spark-doris-connector/dependency-reduced-pom.xml
 spark-doris-connector/output/
 spark-doris-connector/target/
+manager/dm-agent/dm-agent.iml
+manager/dm-agent/target/
+manager/dm-common/dm-common.iml
+manager/dm-common/target/
+manager/dm-server/dm-server.iml
+manager/dm-server/target/
+manager/doris-manager.iml
+manager/general/general.iml
+manager/manager-server/manager-server.iml
+manager/manager-server/src/main/resources/web-resource/
+manager/manager-server/target/
+manager/manager/manager.iml
+manager/manager/target/
+manager/resource-common/resource-common.iml
+manager/resource-common/target/
+manager/general/target/

Review Comment:
   manager/**/target
   manager/**/*.iml



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org