You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/07/24 02:00:42 UTC

[kudu-CR] [log-test] clean-up on WAL entry test operations

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11028


Change subject: [log-test] clean-up on WAL entry test operations
......................................................................

[log-test] clean-up on WAL entry test operations

Change-Id: I01ef7798c63c18cb03df5969fc73bbb0ec65111b
---
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log-test.cc
M src/kudu/tablet/tablet_bootstrap-test.cc
3 files changed, 85 insertions(+), 82 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/11028/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I01ef7798c63c18cb03df5969fc73bbb0ec65111b
Gerrit-Change-Number: 11028
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [log-test] clean-up on WAL entry test operations

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/11028 )

Change subject: [log-test] clean-up on WAL entry test operations
......................................................................


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/11028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I01ef7798c63c18cb03df5969fc73bbb0ec65111b
Gerrit-Change-Number: 11028
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [log-test] clean-up on WAL entry test operations

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Tidy Bot from this change.  ( http://gerrit.cloudera.org:8080/11028 )

Change subject: [log-test] clean-up on WAL entry test operations
......................................................................


Removed reviewer Tidy Bot.
-- 
To view, visit http://gerrit.cloudera.org:8080/11028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I01ef7798c63c18cb03df5969fc73bbb0ec65111b
Gerrit-Change-Number: 11028
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [log-test] clean-up on WAL entry test operations

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11028 )

Change subject: [log-test] clean-up on WAL entry test operations
......................................................................


Patch Set 2: Verified+1

Unrelated flakes:
  org.apache.kudu.spark.kudu.DefaultSourceTest.classMethod
  org.apache.kudu.client.TestSecurity.testRenewAndReacquireKeberosCredentials


-- 
To view, visit http://gerrit.cloudera.org:8080/11028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01ef7798c63c18cb03df5969fc73bbb0ec65111b
Gerrit-Change-Number: 11028
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Jul 2018 04:40:03 +0000
Gerrit-HasComments: No

[kudu-CR] [log-test] clean-up on WAL entry test operations

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11028 )

Change subject: [log-test] clean-up on WAL entry test operations
......................................................................

[log-test] clean-up on WAL entry test operations

Change-Id: I01ef7798c63c18cb03df5969fc73bbb0ec65111b
Reviewed-on: http://gerrit.cloudera.org:8080/11028
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log-test.cc
M src/kudu/tablet/tablet_bootstrap-test.cc
3 files changed, 95 insertions(+), 93 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I01ef7798c63c18cb03df5969fc73bbb0ec65111b
Gerrit-Change-Number: 11028
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [log-test] clean-up on WAL entry test operations

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/11028 )

Change subject: [log-test] clean-up on WAL entry test operations
......................................................................


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/11028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I01ef7798c63c18cb03df5969fc73bbb0ec65111b
Gerrit-Change-Number: 11028
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [log-test] clean-up on WAL entry test operations

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11028 )

Change subject: [log-test] clean-up on WAL entry test operations
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01ef7798c63c18cb03df5969fc73bbb0ec65111b
Gerrit-Change-Number: 11028
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 24 Jul 2018 04:36:59 +0000
Gerrit-HasComments: No

[kudu-CR] [log-test] clean-up on WAL entry test operations

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11028 )

Change subject: [log-test] clean-up on WAL entry test operations
......................................................................


Patch Set 1: Verified+1

Unrelated flake:
  org.apache.kudu.backup.TestKuduBackup.Random Backup and Restore


-- 
To view, visit http://gerrit.cloudera.org:8080/11028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01ef7798c63c18cb03df5969fc73bbb0ec65111b
Gerrit-Change-Number: 11028
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Jul 2018 02:56:08 +0000
Gerrit-HasComments: No

[kudu-CR] [log-test] clean-up on WAL entry test operations

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11028 )

Change subject: [log-test] clean-up on WAL entry test operations
......................................................................

[log-test] clean-up on WAL entry test operations

Change-Id: I01ef7798c63c18cb03df5969fc73bbb0ec65111b
---
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log-test.cc
M src/kudu/tablet/tablet_bootstrap-test.cc
3 files changed, 95 insertions(+), 93 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/11028/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I01ef7798c63c18cb03df5969fc73bbb0ec65111b
Gerrit-Change-Number: 11028
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>