[jira] [Comment Edited] (SLING-6392) JCR Installer: Symbolic name changes on a bundle file is not properly supported

["Konrad Windszus (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-6392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745687#comment-15745687 ] 

Konrad Windszus edited comment on SLING-6392 at 12/13/16 5:26 PM:
------------------------------------------------------------------

The reason for that is that {{o.a.s.installer.provider.jcr.impl.FileNodeConverter}} return in its convert method a {{InstallableResource}} with an id equal to the path. This is for sure not uniquely identifying a bundle, because the path may stay the same although the symbolic bundle name may change. It would be good to evaluate the manifest header in case you are dealing with a bundle and to at least include the symbolic name in the {{InstallableResource}} id. That is necessary because based on the ID it is determined whether a bundle has been remove/added or upgraded.
[~cziegeler] You are most familiar with the code, does the change of the {{InstallableResource.id}} sound reasonable to you? What about compatibility if we now change the id?


was (Author: kwin):
The reason for that is that {{o.a.s.installer.provider.jcr.impl.FileNodeConverter}} return {{InstallableResource}} with an id equal to the path. This is for sure not uniquely identifying a bundle, because the path may stay the same although the symbolic bundle name may change. It would be good to evaluate the manifest header in case you are dealing with a bundle and to at least include the symbolic name in the {{InstallableResource}} id. That is necessary because based on the ID it is determined whether a bundle has been remove/added or upgraded.
[~cziegeler] You are most familiar with the code, does the change of the {{InstallableResource.id}} sound reasonable to you? What about compatibility if we now change the id?

> JCR Installer: Symbolic name changes on a bundle file is not properly supported
> -------------------------------------------------------------------------------
>
>                 Key: SLING-6392
>                 URL: https://issues.apache.org/jira/browse/SLING-6392
>             Project: Sling
>          Issue Type: Bug
>    Affects Versions: Installer Core 3.6.8, JCR Installer 3.1.18
>            Reporter: Konrad Windszus
>
> After deploying bundle with symbolic name {{A}} to JCR location {{/apps/myapp/install/mybundle.jar}} it is correctly being picked up and deployed in Apache Felix. Now the symbolic name has been changed to {{B}} and the updated JAR deployed to the same JCR location  {{/apps/myapp/install/mybundle.jar}} the bundle is not correctly deployed.
> The OSGI installer console exposes that both bundles {{A}} and {{B}} are in state {{Installed}} but the /system/console/bundle only shows bundle {{A}} but not {{B}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)