You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "Markus Karg (JIRA)" <ji...@apache.org> on 2019/04/04 20:21:00 UTC

[jira] [Commented] (MSHADE-316) Explicit minijar includes

    [ https://issues.apache.org/jira/browse/MSHADE-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16810254#comment-16810254 ] 

Markus Karg commented on MSHADE-316:
------------------------------------

[~rfscholte] Shall I provide a PR for that? For which solution, "explicit minijar exceptions" or "useDefaultIncludes=true"? Both solve the same problem, but have different side aspects (positive and negative).

> Explicit minijar includes
> -------------------------
>
>                 Key: MSHADE-316
>                 URL: https://issues.apache.org/jira/browse/MSHADE-316
>             Project: Maven Shade Plugin
>          Issue Type: Improvement
>            Reporter: Markus Karg
>            Priority: Major
>
> Minijar currently respects includes, but these have a drawback: Once you defined an include, the _default includes_ are gone! But what you actually want to have when combining minijar with includes is just an "exception" to minijar's filtering, not a complete replacement of the default includes!
> So what we need to make this work intuitively is either "explicit minijar exceptions", or a "useDefaultIncludes=true" option that turns the notion from "replace default includes by the single given include" to "add the single given include ontop of the default includes".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)