You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/29 17:58:07 UTC
[GitHub] [pulsar] david-streamlio opened a new issue #8162: Create a new interface in the org.apache.pulsar.io.core package that both the source and sink contexts could extend
david-streamlio opened a new issue #8162:
URL: https://github.com/apache/pulsar/issues/8162
**Is your enhancement request related to a problem? Please describe.**
Both the SourceContext and SinkContext contain a lot of duplicate method definitions that provide the same functionality. If someone wanted to write a class that accessed one of these functions, then it would be necessary to create two classes; one for sources and one for sinks.
One such example would be gaining access to `getState` and `putState` methods, and one wanted to write a DAO class to simplify the storage of state. Currently, you would have to write a SinkStorageDAO that takes in a SourceContext object and a SourceStorageDAO that takes in a SinkContext object even though we are really access the same method.
**Describe the solution you'd like**
Move all of the duplicate method definitions inside the SourceContext and SinkContext interfaces into a single interface called `Context` that both of the existing Context objects would then extend.
**Describe alternatives you've considered**
Maintaining duplicate libraries to support Sources and Sinks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] david-streamlio closed issue #8162: Create a new interface in the org.apache.pulsar.io.core package that both the source and sink contexts could extend
Posted by GitBox <gi...@apache.org>.
david-streamlio closed issue #8162:
URL: https://github.com/apache/pulsar/issues/8162
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] david-streamlio commented on issue #8162: Create a new interface in the org.apache.pulsar.io.core package that both the source and sink contexts could extend
Posted by GitBox <gi...@apache.org>.
david-streamlio commented on issue #8162:
URL: https://github.com/apache/pulsar/issues/8162#issuecomment-797099080
This has been resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org