You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/06/02 13:58:03 UTC
[GitHub] [dubbo-go-pixiu] ztelur opened a new pull request, #437: [bugfix] healthchecker block the main gor
ztelur opened a new pull request, #437:
URL: https://github.com/apache/dubbo-go-pixiu/pull/437
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
fix bug that healtchchecker block the main gor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks merged pull request #437: [bugfix] healthchecker block the main gor
Posted by GitBox <gi...@apache.org>.
AlexStocks merged PR #437:
URL: https://github.com/apache/dubbo-go-pixiu/pull/437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] ztelur commented on a diff in pull request #437: [bugfix] healthchecker block the main gor
Posted by GitBox <gi...@apache.org>.
ztelur commented on code in PR #437:
URL: https://github.com/apache/dubbo-go-pixiu/pull/437#discussion_r889501632
##########
pkg/cluster/healthcheck/healthcheck.go:
##########
@@ -147,7 +147,9 @@ func (hc *HealthChecker) startCheck(endpoint *model.Endpoint) {
if _, ok := hc.checkers[addr]; !ok {
c := newChecker(endpoint, hc)
hc.checkers[addr] = c
- c.Start()
Review Comment:
fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z commented on a diff in pull request #437: [bugfix] healthchecker block the main gor
Posted by GitBox <gi...@apache.org>.
mark4z commented on code in PR #437:
URL: https://github.com/apache/dubbo-go-pixiu/pull/437#discussion_r888027555
##########
pkg/cluster/healthcheck/healthcheck.go:
##########
@@ -147,7 +147,9 @@ func (hc *HealthChecker) startCheck(endpoint *model.Endpoint) {
if _, ok := hc.checkers[addr]; !ok {
c := newChecker(endpoint, hc)
hc.checkers[addr] = c
- c.Start()
Review Comment:
why not go c.Start()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org