You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/08 07:36:00 UTC

[GitHub] [kafka] chia7712 commented on a change in pull request #9391: MINOR: fix potential NPT in PartitionData.equals

chia7712 commented on a change in pull request #9391:
URL: https://github.com/apache/kafka/pull/9391#discussion_r501507673



##########
File path: clients/src/test/java/org/apache/kafka/common/requests/OffsetFetchResponseTest.java
##########
@@ -159,14 +159,14 @@ public void testShouldThrottle() {
 
     @Test
     public void testNullableMetadata() {
+        PartitionData pd = new PartitionData(
+            offset,
+            leaderEpochOne,
+            null,
+            Errors.UNKNOWN_TOPIC_OR_PARTITION);
+        assertEquals(pd, pd);

Review comment:
       thanks for this quickly and meaningful review and I will copy that :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org