You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/04/26 21:35:13 UTC

[GitHub] [echarts] Bilge opened a new pull request #14806: Changed LineEndLabelOption.valueAnimation to be optional.

Bilge opened a new pull request #14806:
URL: https://github.com/apache/echarts/pull/14806


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Changes `series: {endLabel: {valueAnimation: bool}}` to be optional, so `valueAnimation` does not have to be specified every time `endLabel` is specified.
   
   ### Fixed issues
   
   Cannot specify `endLabel: {}` without TS error:
   
   >TS2741: Property 'valueAnimation' is missing in type '{}' but required in type 'LineEndLabelOption'.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14806: Changed LineEndLabelOption.valueAnimation to be optional.

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14806:
URL: https://github.com/apache/echarts/pull/14806#issuecomment-827161177


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang merged pull request #14806: Changed LineEndLabelOption.valueAnimation to be optional.

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #14806:
URL: https://github.com/apache/echarts/pull/14806


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org