You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/02/14 07:39:56 UTC
[GitHub] [lucene] vigyasharma opened a new pull request #677: LUCENE-10084: Rewrite DocValuesFieldExistsQuery to MatchAllDocsQuery when all docs have the field
vigyasharma opened a new pull request #677:
URL: https://github.com/apache/lucene/pull/677
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene:
* https://issues.apache.org/jira/projects/LUCENE
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
LUCENE must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Since all documents are required to use the same features ([LUCENE-9334](https://issues.apache.org/jira/browse/LUCENE-9334)) we could rewrite DocValuesFieldExistsQuery to a MatchAllDocsQuery whenever terms or points have a docCount that is equal to maxDoc.
# Solution
Rewrite `DocValuesFieldExistsQuery` to a `MatchAllDocsQuery` when `docCount == maxDoc`
# Tests
Unit tests:
1. All docs have terms
2. All docs have PointValues
3. Some docs are missing either Terms or PointValues. Query is not rewritten.
4. All docs have the same fields, but they're neither Terms nor PointValues. Rewrite evaluation logic skips this case as it would need an iteration over all the docs.
5. Existing tests pass.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jtibshirani commented on a change in pull request #677: LUCENE-10084: Rewrite DocValuesFieldExistsQuery to MatchAllDocsQuery when all docs have the field
Posted by GitBox <gi...@apache.org>.
jtibshirani commented on a change in pull request #677:
URL: https://github.com/apache/lucene/pull/677#discussion_r807297322
##########
File path: lucene/core/src/test/org/apache/lucene/search/TestDocValuesFieldExistsQuery.java
##########
@@ -38,6 +39,100 @@
public class TestDocValuesFieldExistsQuery extends LuceneTestCase {
+ public void testRewriteWithTermsPresent() throws IOException {
+ Directory dir = newDirectory();
+ RandomIndexWriter iw = new RandomIndexWriter(random(), dir);
+ final int numDocs = atLeast(100);
+ for (int i = 0; i < numDocs; ++i) {
+ Document doc = new Document();
+ doc.add(new StringField("f", random().nextBoolean() ? "yes" : "no", Store.NO));
+ iw.addDocument(doc);
+ }
+ iw.commit();
+ final IndexReader reader = iw.getReader();
+ final IndexSearcher searcher = newSearcher(reader);
+ iw.close();
+
+ Query query = new DocValuesFieldExistsQuery("f");
+ Query rewrittenQuery = query.rewrite(reader);
+ assertTrue(rewrittenQuery instanceof MatchAllDocsQuery);
+ assertSameMatches(searcher, query, rewrittenQuery, false);
Review comment:
I think we can skip these `assertSameMatches`, because we always rewrite the query as part of the search. So it is not asserting anything insightful about `DocValuesFieldExistsQuery`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jtibshirani merged pull request #677: LUCENE-10084: Rewrite DocValuesFieldExistsQuery to MatchAllDocsQuery when all docs have the field
Posted by GitBox <gi...@apache.org>.
jtibshirani merged pull request #677:
URL: https://github.com/apache/lucene/pull/677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] vigyasharma commented on pull request #677: LUCENE-10084: Rewrite DocValuesFieldExistsQuery to MatchAllDocsQuery when all docs have the field
Posted by GitBox <gi...@apache.org>.
vigyasharma commented on pull request #677:
URL: https://github.com/apache/lucene/pull/677#issuecomment-1042264970
> This looks great. I left a tiny comment related to tests. Could you also add an entry to `CHANGES.txt` under "Lucene 9.1.0"?
Thank you for reviewing this PR, @jtibshirani. I've added the Changes entry and updates UTs to not assert on the search result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] LuXugang commented on a change in pull request #677: LUCENE-10084: Rewrite DocValuesFieldExistsQuery to MatchAllDocsQuery when all docs have the field
Posted by GitBox <gi...@apache.org>.
LuXugang commented on a change in pull request #677:
URL: https://github.com/apache/lucene/pull/677#discussion_r812597747
##########
File path: lucene/core/src/java/org/apache/lucene/search/DocValuesFieldExistsQuery.java
##########
@@ -64,6 +67,24 @@ public void visit(QueryVisitor visitor) {
}
}
+ @Override
+ public Query rewrite(IndexReader reader) throws IOException {
+ int rewritableReaders = 0;
+ for (LeafReaderContext context : reader.leaves()) {
+ LeafReader leaf = context.reader();
+ Terms terms = leaf.terms(field);
+ PointValues pointValues = leaf.getPointValues(field);
+ if ((terms != null && terms.getDocCount() == leaf.maxDoc())
Review comment:
If condition false, maybe we should break for loop early?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org