You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Peter Cseh <ge...@cloudera.com> on 2017/01/24 13:25:15 UTC
Review Request 55879: OOZIE-2777 Config-default.xml longer than 64k
results in java.io.UTFDataFormatException
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/
-----------------------------------------------------------
Review request for oozie.
Repository: oozie-git
Description
-------
Config-default.xml longer than 64k results in java.io.UTFDataFormatException
https://issues.apache.org/jira/browse/OOZIE-2777
Diffs
-----
core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java PRE-CREATION
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java a06595d3b2b99dbe33ef5d55208435aaec151e1a
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 2b13e6701226b7236d101d738aba6b6ebbabf4e5
core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 496b0086f840c0c6fc60a74bdb3dc382c4db2612
core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 47ff8ca2751926bb728ea3eba5d7fe11282c3176
core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java PRE-CREATION
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java PRE-CREATION
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java a3c7b142d08101e2bb03737871db939133bd3cd2
Diff: https://reviews.apache.org/r/55879/diff/
Testing
-------
Thanks,
Peter Cseh
Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than
64k results in java.io.UTFDataFormatException
Posted by András Piros <an...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/#review162813
-----------------------------------------------------------
Ship it!
Ship It!
- Andr�s Piros
On Jan. 24, 2017, 1:25 p.m., Peter Cseh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55879/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2017, 1:25 p.m.)
>
>
> Review request for oozie.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Config-default.xml longer than 64k results in java.io.UTFDataFormatException
> https://issues.apache.org/jira/browse/OOZIE-2777
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java PRE-CREATION
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java a06595d3b2b99dbe33ef5d55208435aaec151e1a
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 2b13e6701226b7236d101d738aba6b6ebbabf4e5
> core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 496b0086f840c0c6fc60a74bdb3dc382c4db2612
> core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 47ff8ca2751926bb728ea3eba5d7fe11282c3176
> core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java PRE-CREATION
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java PRE-CREATION
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java a3c7b142d08101e2bb03737871db939133bd3cd2
>
> Diff: https://reviews.apache.org/r/55879/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Peter Cseh
>
>
Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than
64k results in java.io.UTFDataFormatException
Posted by Peter Bacsko <pb...@cloudera.com>.
> On jan. 24, 2017, 2:50 du, Peter Bacsko wrote:
> > core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java, line 39
> > <https://reviews.apache.org/r/55879/diff/1/?file=1613538#file1613538line39>
> >
> > I'd prefer a deterministic behaviour in an unit test.
> >
> > I think it's better to use Strings.repeat() from Guava.
>
> Peter Cseh wrote:
> I like the idea of random testing as it might bring out issues we're not think about. E.g. that some charaters are represented with more than 2 bytes in UTF-8
In that case, tests are not reproducible. It makes sense though, but if it fails, you won't know which was the input that caused the failure.
IMO it's better to supply a string which causes characters to be serialized with different byte lengths (1/2/3), then repeat this string until the desired length is not reached.
Example:
public static String TEST_STRING = "aabcdef?���?��\u0800\u0850\u0900";
The last three chars will be encoded to a 3-byte sequence.
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/#review162812
-----------------------------------------------------------
On jan. 24, 2017, 4:30 du, Peter Cseh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55879/
> -----------------------------------------------------------
>
> (Updated jan. 24, 2017, 4:30 du)
>
>
> Review request for oozie.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Config-default.xml longer than 64k results in java.io.UTFDataFormatException
> https://issues.apache.org/jira/browse/OOZIE-2777
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java PRE-CREATION
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 2b13e6701226b7236d101d738aba6b6ebbabf4e5
> core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 496b0086f840c0c6fc60a74bdb3dc382c4db2612
> core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 47ff8ca2751926bb728ea3eba5d7fe11282c3176
> core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java PRE-CREATION
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java PRE-CREATION
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java a3c7b142d08101e2bb03737871db939133bd3cd2
> core/src/test/resources/oldWorkFlowApp.serialized PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55879/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Peter Cseh
>
>
Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than
64k results in java.io.UTFDataFormatException
Posted by Peter Cseh <ge...@cloudera.com>.
> On Jan. 24, 2017, 2:50 p.m., Peter Bacsko wrote:
> > core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java, line 33
> > <https://reviews.apache.org/r/55879/diff/1/?file=1613533#file1613533line33>
> >
> > Is it still 60k? Not 20k?
I'm looking at the size of the byte array now, not the string.
> On Jan. 24, 2017, 2:50 p.m., Peter Bacsko wrote:
> > core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java, line 34
> > <https://reviews.apache.org/r/55879/diff/1/?file=1613538#file1613538line34>
> >
> > What about the case when the number of characters are below 20k?
It tests with a string of lenght 1, 10001, 20001 .... 140001.
> On Jan. 24, 2017, 2:50 p.m., Peter Bacsko wrote:
> > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java, line 32
> > <https://reviews.apache.org/r/55879/diff/1/?file=1613539#file1613539line32>
> >
> > Does it have to extend XTestCase?
Yes, LiteWorkflowApp needs some services. It was not started as one.
> On Jan. 24, 2017, 2:50 p.m., Peter Bacsko wrote:
> > core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java, line 39
> > <https://reviews.apache.org/r/55879/diff/1/?file=1613538#file1613538line39>
> >
> > I'd prefer a deterministic behaviour in an unit test.
> >
> > I think it's better to use Strings.repeat() from Guava.
I like the idea of random testing as it might bring out issues we're not think about. E.g. that some charaters are represented with more than 2 bytes in UTF-8
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/#review162812
-----------------------------------------------------------
On Jan. 24, 2017, 1:25 p.m., Peter Cseh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55879/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2017, 1:25 p.m.)
>
>
> Review request for oozie.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Config-default.xml longer than 64k results in java.io.UTFDataFormatException
> https://issues.apache.org/jira/browse/OOZIE-2777
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java PRE-CREATION
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java a06595d3b2b99dbe33ef5d55208435aaec151e1a
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 2b13e6701226b7236d101d738aba6b6ebbabf4e5
> core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 496b0086f840c0c6fc60a74bdb3dc382c4db2612
> core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 47ff8ca2751926bb728ea3eba5d7fe11282c3176
> core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java PRE-CREATION
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java PRE-CREATION
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java a3c7b142d08101e2bb03737871db939133bd3cd2
>
> Diff: https://reviews.apache.org/r/55879/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Peter Cseh
>
>
Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than
64k results in java.io.UTFDataFormatException
Posted by Peter Bacsko <pb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/#review162812
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java (line 33)
<https://reviews.apache.org/r/55879/#comment234188>
Is it still 60k? Not 20k?
core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java (line 38)
<https://reviews.apache.org/r/55879/#comment234189>
Typo
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java (line 131)
<https://reviews.apache.org/r/55879/#comment234190>
Is this code path covered with test?
core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java (line 34)
<https://reviews.apache.org/r/55879/#comment234187>
What about the case when the number of characters are below 20k?
core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java (line 39)
<https://reviews.apache.org/r/55879/#comment234186>
I'd prefer a deterministic behaviour in an unit test.
I think it's better to use Strings.repeat() from Guava.
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java (line 32)
<https://reviews.apache.org/r/55879/#comment234185>
Does it have to extend XTestCase?
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java (line 45)
<https://reviews.apache.org/r/55879/#comment234191>
Shouldn't be a class variable if it's used in only one method. Also, probably we should stick to a deterministic input.
- Peter Bacsko
On jan. 24, 2017, 1:25 du, Peter Cseh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55879/
> -----------------------------------------------------------
>
> (Updated jan. 24, 2017, 1:25 du)
>
>
> Review request for oozie.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Config-default.xml longer than 64k results in java.io.UTFDataFormatException
> https://issues.apache.org/jira/browse/OOZIE-2777
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java PRE-CREATION
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java a06595d3b2b99dbe33ef5d55208435aaec151e1a
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 2b13e6701226b7236d101d738aba6b6ebbabf4e5
> core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 496b0086f840c0c6fc60a74bdb3dc382c4db2612
> core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 47ff8ca2751926bb728ea3eba5d7fe11282c3176
> core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java PRE-CREATION
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java PRE-CREATION
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java a3c7b142d08101e2bb03737871db939133bd3cd2
>
> Diff: https://reviews.apache.org/r/55879/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Peter Cseh
>
>
Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than
64k results in java.io.UTFDataFormatException
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/#review163679
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On Jan. 31, 2017, 2:10 p.m., Peter Cseh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55879/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 2:10 p.m.)
>
>
> Review request for oozie.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Config-default.xml longer than 64k results in java.io.UTFDataFormatException
> https://issues.apache.org/jira/browse/OOZIE-2777
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java PRE-CREATION
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java a06595d3b2b99dbe33ef5d55208435aaec151e1a
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 2b13e6701226b7236d101d738aba6b6ebbabf4e5
> core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 496b0086f840c0c6fc60a74bdb3dc382c4db2612
> core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 47ff8ca2751926bb728ea3eba5d7fe11282c3176
> core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java PRE-CREATION
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java PRE-CREATION
> core/src/test/resources/oldWorkFlowApp.serialized PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55879/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Peter Cseh
>
>
Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than
64k results in java.io.UTFDataFormatException
Posted by Peter Bacsko <pb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/#review163799
-----------------------------------------------------------
Ship it!
Ship It!
- Peter Bacsko
On jan. 31, 2017, 2:10 du, Peter Cseh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55879/
> -----------------------------------------------------------
>
> (Updated jan. 31, 2017, 2:10 du)
>
>
> Review request for oozie.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Config-default.xml longer than 64k results in java.io.UTFDataFormatException
> https://issues.apache.org/jira/browse/OOZIE-2777
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java PRE-CREATION
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java a06595d3b2b99dbe33ef5d55208435aaec151e1a
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 2b13e6701226b7236d101d738aba6b6ebbabf4e5
> core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 496b0086f840c0c6fc60a74bdb3dc382c4db2612
> core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 47ff8ca2751926bb728ea3eba5d7fe11282c3176
> core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java PRE-CREATION
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java PRE-CREATION
> core/src/test/resources/oldWorkFlowApp.serialized PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55879/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Peter Cseh
>
>
Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than
64k results in java.io.UTFDataFormatException
Posted by Peter Cseh <ge...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/
-----------------------------------------------------------
(Updated Jan. 31, 2017, 2:10 p.m.)
Review request for oozie.
Repository: oozie-git
Description
-------
Config-default.xml longer than 64k results in java.io.UTFDataFormatException
https://issues.apache.org/jira/browse/OOZIE-2777
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java PRE-CREATION
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java a06595d3b2b99dbe33ef5d55208435aaec151e1a
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 2b13e6701226b7236d101d738aba6b6ebbabf4e5
core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 496b0086f840c0c6fc60a74bdb3dc382c4db2612
core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 47ff8ca2751926bb728ea3eba5d7fe11282c3176
core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java PRE-CREATION
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java PRE-CREATION
core/src/test/resources/oldWorkFlowApp.serialized PRE-CREATION
Diff: https://reviews.apache.org/r/55879/diff/
Testing
-------
Thanks,
Peter Cseh
Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than
64k results in java.io.UTFDataFormatException
Posted by Peter Cseh <ge...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/
-----------------------------------------------------------
(Updated Jan. 31, 2017, 2:07 p.m.)
Review request for oozie.
Repository: oozie-git
Description
-------
Config-default.xml longer than 64k results in java.io.UTFDataFormatException
https://issues.apache.org/jira/browse/OOZIE-2777
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java a06595d3b2b99dbe33ef5d55208435aaec151e1a
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 2b13e6701226b7236d101d738aba6b6ebbabf4e5
core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 496b0086f840c0c6fc60a74bdb3dc382c4db2612
core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 47ff8ca2751926bb728ea3eba5d7fe11282c3176
Diff: https://reviews.apache.org/r/55879/diff/
Testing
-------
Thanks,
Peter Cseh
Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than
64k results in java.io.UTFDataFormatException
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/#review163651
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java (line 186)
<https://reviews.apache.org/r/55879/#comment235132>
This can also be reverted. Don't see cred being >64k. In fact I don't think anything is stored in this field.
core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java (line 279)
<https://reviews.apache.org/r/55879/#comment235131>
This can also be reverted. Don't see userRetryPolicy being >64k
- Rohini Palaniswamy
On Jan. 27, 2017, 11:09 a.m., Peter Cseh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55879/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 11:09 a.m.)
>
>
> Review request for oozie.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Config-default.xml longer than 64k results in java.io.UTFDataFormatException
> https://issues.apache.org/jira/browse/OOZIE-2777
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java PRE-CREATION
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java a06595d3b2b99dbe33ef5d55208435aaec151e1a
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 2b13e6701226b7236d101d738aba6b6ebbabf4e5
> core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 496b0086f840c0c6fc60a74bdb3dc382c4db2612
> core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 47ff8ca2751926bb728ea3eba5d7fe11282c3176
> core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java PRE-CREATION
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java PRE-CREATION
> core/src/test/resources/oldWorkFlowApp.serialized PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55879/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Peter Cseh
>
>
Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than
64k results in java.io.UTFDataFormatException
Posted by Peter Cseh <ge...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/
-----------------------------------------------------------
(Updated Jan. 27, 2017, 11:09 a.m.)
Review request for oozie.
Repository: oozie-git
Description
-------
Config-default.xml longer than 64k results in java.io.UTFDataFormatException
https://issues.apache.org/jira/browse/OOZIE-2777
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java PRE-CREATION
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java a06595d3b2b99dbe33ef5d55208435aaec151e1a
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 2b13e6701226b7236d101d738aba6b6ebbabf4e5
core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 496b0086f840c0c6fc60a74bdb3dc382c4db2612
core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 47ff8ca2751926bb728ea3eba5d7fe11282c3176
core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java PRE-CREATION
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java PRE-CREATION
core/src/test/resources/oldWorkFlowApp.serialized PRE-CREATION
Diff: https://reviews.apache.org/r/55879/diff/
Testing
-------
Thanks,
Peter Cseh
Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than
64k results in java.io.UTFDataFormatException
Posted by Peter Cseh <ge...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/
-----------------------------------------------------------
(Updated Jan. 26, 2017, 10:29 p.m.)
Review request for oozie.
Repository: oozie-git
Description
-------
Config-default.xml longer than 64k results in java.io.UTFDataFormatException
https://issues.apache.org/jira/browse/OOZIE-2777
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java PRE-CREATION
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java a06595d3b2b99dbe33ef5d55208435aaec151e1a
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 2b13e6701226b7236d101d738aba6b6ebbabf4e5
core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 496b0086f840c0c6fc60a74bdb3dc382c4db2612
core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 47ff8ca2751926bb728ea3eba5d7fe11282c3176
core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java PRE-CREATION
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java PRE-CREATION
core/src/test/resources/oldWorkFlowApp.serialized PRE-CREATION
Diff: https://reviews.apache.org/r/55879/diff/
Testing
-------
Thanks,
Peter Cseh
Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than
64k results in java.io.UTFDataFormatException
Posted by Peter Cseh <ge...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/
-----------------------------------------------------------
(Updated Jan. 26, 2017, 1:33 p.m.)
Review request for oozie.
Repository: oozie-git
Description
-------
Config-default.xml longer than 64k results in java.io.UTFDataFormatException
https://issues.apache.org/jira/browse/OOZIE-2777
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java PRE-CREATION
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java a06595d3b2b99dbe33ef5d55208435aaec151e1a
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 2b13e6701226b7236d101d738aba6b6ebbabf4e5
core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 496b0086f840c0c6fc60a74bdb3dc382c4db2612
core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 47ff8ca2751926bb728ea3eba5d7fe11282c3176
core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java PRE-CREATION
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java PRE-CREATION
core/src/test/resources/oldWorkFlowApp.serialized PRE-CREATION
Diff: https://reviews.apache.org/r/55879/diff/
Testing
-------
Thanks,
Peter Cseh
Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than
64k results in java.io.UTFDataFormatException
Posted by Peter Cseh <ge...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/
-----------------------------------------------------------
(Updated Jan. 25, 2017, 12:59 p.m.)
Review request for oozie.
Repository: oozie-git
Description
-------
Config-default.xml longer than 64k results in java.io.UTFDataFormatException
https://issues.apache.org/jira/browse/OOZIE-2777
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java PRE-CREATION
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 2b13e6701226b7236d101d738aba6b6ebbabf4e5
core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 496b0086f840c0c6fc60a74bdb3dc382c4db2612
core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 47ff8ca2751926bb728ea3eba5d7fe11282c3176
core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java PRE-CREATION
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java PRE-CREATION
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java a3c7b142d08101e2bb03737871db939133bd3cd2
core/src/test/resources/oldWorkFlowApp.serialized PRE-CREATION
Diff: https://reviews.apache.org/r/55879/diff/
Testing
-------
Thanks,
Peter Cseh
Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than
64k results in java.io.UTFDataFormatException
Posted by Peter Cseh <ge...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/
-----------------------------------------------------------
(Updated Jan. 25, 2017, 12:35 p.m.)
Review request for oozie.
Repository: oozie-git
Description
-------
Config-default.xml longer than 64k results in java.io.UTFDataFormatException
https://issues.apache.org/jira/browse/OOZIE-2777
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java PRE-CREATION
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 2b13e6701226b7236d101d738aba6b6ebbabf4e5
core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 496b0086f840c0c6fc60a74bdb3dc382c4db2612
core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 47ff8ca2751926bb728ea3eba5d7fe11282c3176
core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java PRE-CREATION
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java PRE-CREATION
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java a3c7b142d08101e2bb03737871db939133bd3cd2
core/src/test/resources/oldWorkFlowApp.serialized PRE-CREATION
Diff: https://reviews.apache.org/r/55879/diff/
Testing
-------
Thanks,
Peter Cseh
Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than
64k results in java.io.UTFDataFormatException
Posted by Peter Cseh <ge...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/
-----------------------------------------------------------
(Updated Jan. 25, 2017, 8:53 a.m.)
Review request for oozie.
Repository: oozie-git
Description
-------
Config-default.xml longer than 64k results in java.io.UTFDataFormatException
https://issues.apache.org/jira/browse/OOZIE-2777
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java PRE-CREATION
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 2b13e6701226b7236d101d738aba6b6ebbabf4e5
core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 496b0086f840c0c6fc60a74bdb3dc382c4db2612
core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 47ff8ca2751926bb728ea3eba5d7fe11282c3176
core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java PRE-CREATION
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java PRE-CREATION
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java a3c7b142d08101e2bb03737871db939133bd3cd2
core/src/test/resources/oldWorkFlowApp.serialized PRE-CREATION
Diff: https://reviews.apache.org/r/55879/diff/
Testing
-------
Thanks,
Peter Cseh
Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than
64k results in java.io.UTFDataFormatException
Posted by Peter Bacsko <pb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/#review162832
-----------------------------------------------------------
- Peter Bacsko
On jan. 24, 2017, 4:30 du, Peter Cseh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55879/
> -----------------------------------------------------------
>
> (Updated jan. 24, 2017, 4:30 du)
>
>
> Review request for oozie.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Config-default.xml longer than 64k results in java.io.UTFDataFormatException
> https://issues.apache.org/jira/browse/OOZIE-2777
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java PRE-CREATION
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 2b13e6701226b7236d101d738aba6b6ebbabf4e5
> core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 496b0086f840c0c6fc60a74bdb3dc382c4db2612
> core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 47ff8ca2751926bb728ea3eba5d7fe11282c3176
> core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java PRE-CREATION
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java PRE-CREATION
> core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java a3c7b142d08101e2bb03737871db939133bd3cd2
> core/src/test/resources/oldWorkFlowApp.serialized PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55879/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Peter Cseh
>
>
Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than
64k results in java.io.UTFDataFormatException
Posted by Peter Cseh <ge...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/
-----------------------------------------------------------
(Updated Jan. 24, 2017, 4:30 p.m.)
Review request for oozie.
Repository: oozie-git
Description
-------
Config-default.xml longer than 64k results in java.io.UTFDataFormatException
https://issues.apache.org/jira/browse/OOZIE-2777
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java PRE-CREATION
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 2b13e6701226b7236d101d738aba6b6ebbabf4e5
core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 496b0086f840c0c6fc60a74bdb3dc382c4db2612
core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 47ff8ca2751926bb728ea3eba5d7fe11282c3176
core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java PRE-CREATION
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java PRE-CREATION
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java a3c7b142d08101e2bb03737871db939133bd3cd2
core/src/test/resources/oldWorkFlowApp.serialized PRE-CREATION
Diff: https://reviews.apache.org/r/55879/diff/
Testing
-------
Thanks,
Peter Cseh
Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than
64k results in java.io.UTFDataFormatException
Posted by Peter Cseh <ge...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55879/
-----------------------------------------------------------
(Updated Jan. 24, 2017, 3:43 p.m.)
Review request for oozie.
Repository: oozie-git
Description
-------
Config-default.xml longer than 64k results in java.io.UTFDataFormatException
https://issues.apache.org/jira/browse/OOZIE-2777
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java PRE-CREATION
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java a06595d3b2b99dbe33ef5d55208435aaec151e1a
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 2b13e6701226b7236d101d738aba6b6ebbabf4e5
core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java 496b0086f840c0c6fc60a74bdb3dc382c4db2612
core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 47ff8ca2751926bb728ea3eba5d7fe11282c3176
core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java PRE-CREATION
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java PRE-CREATION
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java a3c7b142d08101e2bb03737871db939133bd3cd2
Diff: https://reviews.apache.org/r/55879/diff/
Testing
-------
Thanks,
Peter Cseh