You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2009/06/08 17:22:35 UTC

[jira] Created: (CAMEL-1686) Aggregator - Completion Predicate being evaluated on-the-fly

Aggregator - Completion Predicate being evaluated on-the-fly
------------------------------------------------------------

                 Key: CAMEL-1686
                 URL: https://issues.apache.org/activemq/browse/CAMEL-1686
             Project: Apache Camel
          Issue Type: Improvement
          Components: camel-core
    Affects Versions: 1.6.2, 2.0.0
            Reporter: Claus Ibsen
             Fix For: 2.1.0


When using the completion predicate with the aggregator its not evaluated on-the-fly. So the completion is dependent on timeout or batch size before its evaluated.
We should let Camel be able to aggregate on-the-fly so the completion predicate also can trigger a send from the aggregator.




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1686) Aggregator - Completion Predicate being evaluated on-the-fly

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=57610#action_57610 ] 

Claus Ibsen commented on CAMEL-1686:
------------------------------------

trunk: 910860.

Work in progress

> Aggregator - Completion Predicate being evaluated on-the-fly
> ------------------------------------------------------------
>
>                 Key: CAMEL-1686
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1686
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.6.2, 2.0.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.3.0
>
>
> When using the completion predicate with the aggregator its not evaluated on-the-fly. So the completion is dependent on timeout or batch size before its evaluated.
> We should let Camel be able to aggregate on-the-fly so the completion predicate also can trigger a send from the aggregator.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1686) Aggregator - Completion Predicate being evaluated on-the-fly

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52126#action_52126 ] 

Claus Ibsen commented on CAMEL-1686:
------------------------------------

[17:14]  <davsclaus> well the issue is when you use completion predicate it waits until either timeout or a batch size limit was hit
[17:15]  <davsclaus> so the problem is when you use a completion predicate
[17:15]  <davsclaus> it cannot check it on-the-fly
[17:15]  <jstrachan> ah :)
[17:15]  <jstrachan> so we need it to wait unil "either timeout or a batch size limit was hit" or completion predicate true?
[17:18]  <davsclaus> yeah the latter is missing
[17:18]  <davsclaus> that is because that one is computed when the aggregation occurs (and it starts by the first 2)
[17:19]  <davsclaus> what it does is just batching up,
[17:19]  <davsclaus> so we should let it aggregate on-the-fly and let it be able to trigger completion if the completion predicate = true
[17:19]  <jstrachan> agreed



> Aggregator - Completion Predicate being evaluated on-the-fly
> ------------------------------------------------------------
>
>                 Key: CAMEL-1686
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1686
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.6.2, 2.0.0
>            Reporter: Claus Ibsen
>             Fix For: 2.1.0
>
>
> When using the completion predicate with the aggregator its not evaluated on-the-fly. So the completion is dependent on timeout or batch size before its evaluated.
> We should let Camel be able to aggregate on-the-fly so the completion predicate also can trigger a send from the aggregator.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CAMEL-1686) Aggregator - Completion Predicate being evaluated on-the-fly

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen reassigned CAMEL-1686:
----------------------------------

    Assignee: Claus Ibsen

> Aggregator - Completion Predicate being evaluated on-the-fly
> ------------------------------------------------------------
>
>                 Key: CAMEL-1686
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1686
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.6.2, 2.0.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.3.0
>
>
> When using the completion predicate with the aggregator its not evaluated on-the-fly. So the completion is dependent on timeout or batch size before its evaluated.
> We should let Camel be able to aggregate on-the-fly so the completion predicate also can trigger a send from the aggregator.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1686) Aggregator - Completion Predicate being evaluated on-the-fly

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=57570#action_57570 ] 

Claus Ibsen commented on CAMEL-1686:
------------------------------------

trunk: 909995.

I have fixed to let completion predicate be evaluated on the fly which allows it to trigger before the batch timeout.

There is one caveat as the predicate is being invoked twice:
- eager on the fly
- and a 2nd time when aggregation takes place

To remedy this the aggregation must also happen on the fly which is a much bigger task to implement.

> Aggregator - Completion Predicate being evaluated on-the-fly
> ------------------------------------------------------------
>
>                 Key: CAMEL-1686
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1686
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.6.2, 2.0.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.3.0
>
>
> When using the completion predicate with the aggregator its not evaluated on-the-fly. So the completion is dependent on timeout or batch size before its evaluated.
> We should let Camel be able to aggregate on-the-fly so the completion predicate also can trigger a send from the aggregator.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CAMEL-1686) Aggregator - Completion Predicate being evaluated on-the-fly

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-1686.
--------------------------------

    Resolution: Fixed

trunk: 910970.

> Aggregator - Completion Predicate being evaluated on-the-fly
> ------------------------------------------------------------
>
>                 Key: CAMEL-1686
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1686
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.6.2, 2.0.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.3.0
>
>
> When using the completion predicate with the aggregator its not evaluated on-the-fly. So the completion is dependent on timeout or batch size before its evaluated.
> We should let Camel be able to aggregate on-the-fly so the completion predicate also can trigger a send from the aggregator.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1686) Aggregator - Completion Predicate being evaluated on-the-fly

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=57618#action_57618 ] 

Claus Ibsen commented on CAMEL-1686:
------------------------------------

trunk: 910948.

Work in progress

> Aggregator - Completion Predicate being evaluated on-the-fly
> ------------------------------------------------------------
>
>                 Key: CAMEL-1686
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1686
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.6.2, 2.0.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.3.0
>
>
> When using the completion predicate with the aggregator its not evaluated on-the-fly. So the completion is dependent on timeout or batch size before its evaluated.
> We should let Camel be able to aggregate on-the-fly so the completion predicate also can trigger a send from the aggregator.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1686) Aggregator - Completion Predicate being evaluated on-the-fly

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=57556#action_57556 ] 

Claus Ibsen commented on CAMEL-1686:
------------------------------------

Okay the tricky part is to aggregate on-the-fly.

I got the completion predicate running now, but you can configure it to use details from the aggregation, which now happens *after* the completion check.
Therefore we need to aggregate on-the-fly as well which takes much more work to archive.

> Aggregator - Completion Predicate being evaluated on-the-fly
> ------------------------------------------------------------
>
>                 Key: CAMEL-1686
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1686
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.6.2, 2.0.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.3.0
>
>
> When using the completion predicate with the aggregator its not evaluated on-the-fly. So the completion is dependent on timeout or batch size before its evaluated.
> We should let Camel be able to aggregate on-the-fly so the completion predicate also can trigger a send from the aggregator.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1686) Aggregator - Completion Predicate being evaluated on-the-fly

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=57582#action_57582 ] 

Claus Ibsen commented on CAMEL-1686:
------------------------------------

I am working on a new AggregateProcessor.

Work in progress

trunk: 910231.

> Aggregator - Completion Predicate being evaluated on-the-fly
> ------------------------------------------------------------
>
>                 Key: CAMEL-1686
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1686
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.6.2, 2.0.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.3.0
>
>
> When using the completion predicate with the aggregator its not evaluated on-the-fly. So the completion is dependent on timeout or batch size before its evaluated.
> We should let Camel be able to aggregate on-the-fly so the completion predicate also can trigger a send from the aggregator.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1686) Aggregator - Completion Predicate being evaluated on-the-fly

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=57611#action_57611 ] 

Claus Ibsen commented on CAMEL-1686:
------------------------------------

trunk: 910890.

Work in progress

> Aggregator - Completion Predicate being evaluated on-the-fly
> ------------------------------------------------------------
>
>                 Key: CAMEL-1686
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1686
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.6.2, 2.0.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.3.0
>
>
> When using the completion predicate with the aggregator its not evaluated on-the-fly. So the completion is dependent on timeout or batch size before its evaluated.
> We should let Camel be able to aggregate on-the-fly so the completion predicate also can trigger a send from the aggregator.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.