You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by emulvaney <gi...@git.apache.org> on 2015/04/07 23:53:33 UTC
[GitHub] storm pull request: STORM-761: An option for new/updated Redis key...
GitHub user emulvaney opened a pull request:
https://github.com/apache/storm/pull/514
STORM-761: An option for new/updated Redis keys to expire in RedisMapState
This is much the same as the mechanism already available via `RedisStateUpdater` for `RedisState` instances. Users can now set `expireIntervalSec` in their `RedisMapState.Options` instance, to set an expiry timeout on each Redis key updated by the state.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/emulvaney/storm feature/expire-in-redis-map-state
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/514.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #514
----
commit c36702e210080b2bc6d59d8f9c0b7307f5926869
Author: eric-mulvaney <er...@kontagent.com>
Date: 2015-04-07T21:24:20Z
Made the keyFactory option public.
It can be set from the public API in other ways. Having it public
means we can set it along with other values like hkey.
commit 410feef51cf7e85267741ca08cdd57a509d1e252
Author: eric-mulvaney <er...@kontagent.com>
Date: 2015-04-07T21:25:03Z
Added expireIntervalSec to RedisMapState.Options
This matches the option available to users of RedisStateUpdater.
Bit heavy when setting top-level keys, since Redis doesn't have
MSETEX to match its SETEX command where we could include an expiry
timeout. Pipelined to mitigate the overhead of needing to issue a
separate command per key.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-761: An option for new/updated Redis key...
Posted by emulvaney <gi...@git.apache.org>.
Github user emulvaney commented on the pull request:
https://github.com/apache/storm/pull/514#issuecomment-91002146
Okay, cluster stuff in place. I don't mind waiting for #504. Just good to get this in at some point, ideally on the 0.10.x-branch (where storm-redis first appeared). Thanks, @HeartSaVioR. :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-761: An option for new/updated Redis key...
Posted by emulvaney <gi...@git.apache.org>.
Github user emulvaney commented on the pull request:
https://github.com/apache/storm/pull/514#issuecomment-108367739
Thanks, everyone. :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-761: An option for new/updated Redis key...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/514#issuecomment-108114170
Note: This has been merged to 0.10.x-branch only.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-761: An option for new/updated Redis key...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/514
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-761: An option for new/updated Redis key...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/514#issuecomment-90784475
LGTM.
Since it's conflicted to my PR #504, it may need to upmerge later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-761: An option for new/updated Redis key...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/514#issuecomment-108083434
Thanks @emulvaney this has been merged and set for the 0.10.0 release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-761: An option for new/updated Redis key...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/514#issuecomment-91072095
@emulvaney
LTGM on new commits. Great!
Actually I also think we should apply all improvements on storm-redis to 0.10.x branch so first impression of storm-redis is better than current 0.10.x branch's.
In order to applying it, we need to confirm Storm committers, especially committer sponsor of storm-redis, @revans2 .
@revans2
Since some contributors want to meet complete version of storm-redis in Storm 0.10.0, how about making a umbrella issue which is for cherry-picking all changes on master branch of storm-redis to 0.10.x branch?
I'll take care of it if you don't mind. I'm thinking about cherry-picking all things to new branch from 0.10.x, and make new PR to let you merge easily.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-761: An option for new/updated Redis key...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/514#issuecomment-107979543
But it needs to be upmerged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-761: An option for new/updated Redis key...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/514#issuecomment-107979489
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---