You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2023/01/02 20:11:32 UTC

[GitHub] [incubator-pekko] jchapuis opened a new pull request, #81: Remove sbtx usage

jchapuis opened a new pull request, #81:
URL: https://github.com/apache/incubator-pekko/pull/81

   Fix for #59 
   
   Replace by prior copy of `.jvmopts-ci` into `.jvmopts` which is the file sbt natively supports
   
   Naive approach, just trying to help, not sure if that's what you expected? 😄  It seems sbt doesn't support a custom filename for jvm opts 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] mdedetrich commented on pull request #81: Remove sbtx usage

Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #81:
URL: https://github.com/apache/incubator-pekko/pull/81#issuecomment-1369608706

   Ah yes thats a fair point, I actually opened `.jvmopts-ci` and I see that some of the options are specific to ci. I actually think that there shouldn't be a problem using it locally but that should be investigated separately.
   
   For now its safer to just keep the same behavior like you implemented, so approving PR. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] mdedetrich merged pull request #81: Remove sbtx usage

Posted by GitBox <gi...@apache.org>.
mdedetrich merged PR #81:
URL: https://github.com/apache/incubator-pekko/pull/81


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] mdedetrich commented on pull request #81: Remove sbtx usage

Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #81:
URL: https://github.com/apache/incubator-pekko/pull/81#issuecomment-1369594221

   > yes indeed, we could rename, that's the alternative. However, naturally, this means these options would also be picked up when starting sbt locally, which is maybe not what we want 🤔 ?
   
   So the underlying point of the issue and this PR is that `sbtx` is actually not used in any distribution if you install sbt the standard way. A lot of functionality over time has moved from `sbtx` to `sbt` and today there is no reason to use sbt. This is why @SethTisue was annoyed with `setup-scala` aliasing `sbt` to `sbtx` because its misleading.
   
   The tl;dr is that nowadays if you have sbt on Linux/Mac/Windows its just using standard sbt (not `sbtx`) and its ignoring those cli options anyways
   
   > Do we actually know if these options are necessary at all? some of them might no longer be relevant, e.g. UseCompressedOops seems to be a default nowadays
   
   That is a fair point but I would fix this in a separate PR just to make things clear.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] jchapuis commented on pull request #81: Remove sbtx usage

Posted by GitBox <gi...@apache.org>.
jchapuis commented on PR #81:
URL: https://github.com/apache/incubator-pekko/pull/81#issuecomment-1369554594

   @mdedetrich yes indeed, we could rename, that's the alternative. However, naturally, this means these options would also be picked up when starting sbt locally, which is maybe not what we want 🤔 ? 
   Do we actually know if these options are necessary at all? some of them might no longer be relevant, e.g. `UseCompressedOops` seems to be a default nowadays


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] jchapuis commented on pull request #81: Remove sbtx usage

Posted by GitBox <gi...@apache.org>.
jchapuis commented on PR #81:
URL: https://github.com/apache/incubator-pekko/pull/81#issuecomment-1369606053

   @mdedetrich thanks yes I think I understand the context of this issue. My only concern was that by renaming `.jvmopts-ci` to `.jvmopts` in the repo, when you start `sbt` (not `sbtx`, just the standard `sbt`), it will actually pickup these options for your local development session (which could be counter-intuitive, as it's "hidden"). Compared to sbtx, it just doesn't allow specifying the file - but the functionality is there with the hardcoded name.  
   
   If that's acceptable, for sure we can rename it and ditch the preliminary copying step. 
   
   But I was guessing here that it had been kept separate to make it clear that these options were only relevant for the CI, and so I thought it relevant to keep this intention 🤷 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org