You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/10/31 03:03:39 UTC
[PR] GH-44578: [Release][Packaging] Verify wheel version [arrow]
kou opened a new pull request, #44593:
URL: https://github.com/apache/arrow/pull/44593
### Rationale for this change
We want to detect binary build from wrong source.
### What changes are included in this PR?
Add version check. If we use wrong source, binary's version is `X.Y.Z-SNAPSHOT` not `X.Y.Z`. So the added check is failed.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44578: [Release][Packaging] Verify wheel version [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44593:
URL: https://github.com/apache/arrow/pull/44593#issuecomment-2450849135
@github-actions crossbow submit verify-rc-binaries-wheels-linux-* verify-rc-binaries-wheels-macos-* --param release=18.0.0 --param rc=0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44578: [Release][Packaging] Verify wheel version [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #44593:
URL: https://github.com/apache/arrow/pull/44593#issuecomment-2449594451
It seems some of the wheels jobs are trying to validate the version:
```
++ python -c 'import pyarrow; print(pyarrow.__version__)'
+ pyarrow_version=19.0.0.dev13
+ '[' 19.0.0.dev13 = HEAD ']'
Failed to verify release candidate. See /tmp/arrow-HEAD.9beIS for details.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44578: [Release][Packaging] Verify wheel version [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44593:
URL: https://github.com/apache/arrow/pull/44593#issuecomment-2450856192
@github-actions crossbow submit wheel-manylinux-2-28-cp310-cp310-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44578: [Release][Packaging] Verify wheel version [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #44593:
URL: https://github.com/apache/arrow/pull/44593#issuecomment-2449475003
@github-actions crossbow submit -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44578: [Release][Packaging] Verify wheel version [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44593:
URL: https://github.com/apache/arrow/pull/44593#issuecomment-2448925316
:warning: GitHub issue #44578 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44578: [Release][Packaging] Verify wheel version [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44593:
URL: https://github.com/apache/arrow/pull/44593#issuecomment-2448927986
Revision: daa2c596ca7456298722002a9f42eff49adc1ae7
Submitted crossbow builds: [ursacomputing/crossbow @ actions-639535b41c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-639535b41c)
|Task|Status|
|----|------|
|verify-rc-binaries-wheels-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11605391532/job/32315710501)|
|verify-rc-binaries-wheels-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11605391839/job/32315711152)|
|verify-rc-binaries-wheels-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11605391584/job/32315710643)|
|verify-rc-binaries-wheels-macos-13-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11605391842/job/32315711126)|
|verify-rc-binaries-wheels-macos-14-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11605391505/job/32315710504)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44578: [Release][Packaging] Verify wheel version [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44593:
URL: https://github.com/apache/arrow/pull/44593#issuecomment-2449102447
@github-actions crossbow submit verify-rc-binaries-wheels-linux-* verify-rc-binaries-wheels-macos-* --param release=18.0.0 --param rc=0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44578: [Release][Packaging] Verify wheel version [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd merged PR #44593:
URL: https://github.com/apache/arrow/pull/44593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44578: [Release][Packaging] Verify wheel version [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44593:
URL: https://github.com/apache/arrow/pull/44593#issuecomment-2449244214
Detected as expected:
AlmaLinux 8
https://github.com/ursacomputing/crossbow/actions/runs/11607347516/job/32320696524#step:6:890
```text
++ python -c 'import pyarrow; print(pyarrow.cpp_build_info.version)'
+ arrow_cpp_version=18.0.0-SNAPSHOT
+ '[' 18.0.0-SNAPSHOT = 18.0.0 ']'
Failed to verify release candidate. See /tmp/arrow-18.0.0.Qi3E1 for details.
```
macos 13
https://github.com/ursacomputing/crossbow/actions/runs/11607347566/job/32320696687#step:7:343
```text
++ python -c 'import pyarrow; print(pyarrow.cpp_build_info.version)'
+ arrow_cpp_version=18.0.0-SNAPSHOT
+ '[' 18.0.0-SNAPSHOT = 18.0.0 ']'
Failed to verify release candidate. See /var/folders/nj/wh528zms06j9t8y7bmlvpmjm0000gn/T/arrow-18.0.0.XXXXX.godSbxKj for details.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44578: [Release][Packaging] Verify wheel version [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44593:
URL: https://github.com/apache/arrow/pull/44593#issuecomment-2450858955
Revision: 426a754c3801e3bae3a737e75e4bd3bcff8bda61
Submitted crossbow builds: [ursacomputing/crossbow @ actions-055c87307e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-055c87307e)
|Task|Status|
|----|------|
|wheel-manylinux-2-28-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11620294441/job/32361763070)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44578: [Release][Packaging] Verify wheel version [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44593:
URL: https://github.com/apache/arrow/pull/44593#issuecomment-2448925934
@github-actions crossbow submit verify-rc-binaries-wheels-linux-* verify-rc-binaries-wheels-macos-* --param release=18.0.0 --param rc=0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44578: [Release][Packaging] Verify wheel version [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44593:
URL: https://github.com/apache/arrow/pull/44593#issuecomment-2450852313
Revision: 426a754c3801e3bae3a737e75e4bd3bcff8bda61
Submitted crossbow builds: [ursacomputing/crossbow @ actions-9ad7231ce8](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9ad7231ce8)
|Task|Status|
|----|------|
|verify-rc-binaries-wheels-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11620229262/job/32361553731)|
|verify-rc-binaries-wheels-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11620229202/job/32361553056)|
|verify-rc-binaries-wheels-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11620229205/job/32361553049)|
|verify-rc-binaries-wheels-macos-13-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11620229275/job/32361554013)|
|verify-rc-binaries-wheels-macos-14-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11620229321/job/32361554329)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44578: [Release][Packaging] Verify wheel version [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44593:
URL: https://github.com/apache/arrow/pull/44593#issuecomment-2449111208
Revision: a0f54359397facd24a1b65ceb3524369fe533df2
Submitted crossbow builds: [ursacomputing/crossbow @ actions-99deba0604](https://github.com/ursacomputing/crossbow/branches/all?query=actions-99deba0604)
|Task|Status|
|----|------|
|verify-rc-binaries-wheels-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11607347516/job/32320696524)|
|verify-rc-binaries-wheels-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11607347601/job/32320696799)|
|verify-rc-binaries-wheels-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11607347449/job/32320696404)|
|verify-rc-binaries-wheels-macos-13-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11607347566/job/32320696687)|
|verify-rc-binaries-wheels-macos-14-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11607347588/job/32320696771)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44578: [Release][Packaging] Verify wheel version [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #44593:
URL: https://github.com/apache/arrow/pull/44593#issuecomment-2453220188
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ab0c857695420f94cc83259494941a68b2762dee.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/32430624250) has more details. It also includes information about 24 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44578: [Release][Packaging] Verify wheel version [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44593:
URL: https://github.com/apache/arrow/pull/44593#issuecomment-2450848356
Good catch! We should not check the version for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44578: [Release][Packaging] Verify wheel version [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44593:
URL: https://github.com/apache/arrow/pull/44593#issuecomment-2449483349
Revision: a0f54359397facd24a1b65ceb3524369fe533df2
Submitted crossbow builds: [ursacomputing/crossbow @ actions-bb57e85699](https://github.com/ursacomputing/crossbow/branches/all?query=actions-bb57e85699)
|Task|Status|
|----|------|
|python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860228/job/32327982817)|
|wheel-macos-monterey-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609861294/job/32327988729)|
|wheel-macos-monterey-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860794/job/32327985656)|
|wheel-macos-monterey-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860820/job/32327986280)|
|wheel-macos-monterey-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609861398/job/32327988972)|
|wheel-macos-monterey-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860711/job/32327985329)|
|wheel-macos-monterey-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609861005/job/32327987312)|
|wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860865/job/32327985993)|
|wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609861124/job/32327987866)|
|wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860460/job/32327983759)|
|wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860694/job/32327985491)|
|wheel-macos-monterey-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860383/job/32327983458)|
|wheel-macos-monterey-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860646/job/32327984635)|
|wheel-manylinux-2-28-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609861143/job/32327987610)|
|wheel-manylinux-2-28-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609861235/job/32327988370)|
|wheel-manylinux-2-28-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860469/job/32327984043)|
|wheel-manylinux-2-28-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860472/job/32327983814)|
|wheel-manylinux-2-28-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860872/job/32327985920)|
|wheel-manylinux-2-28-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609861238/job/32327988367)|
|wheel-manylinux-2-28-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860887/job/32327986397)|
|wheel-manylinux-2-28-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860172/job/32327982551)|
|wheel-manylinux-2-28-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860159/job/32327982596)|
|wheel-manylinux-2-28-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609861356/job/32327989407)|
|wheel-manylinux-2-28-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609861790/job/32327989728)|
|wheel-manylinux-2-28-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609861196/job/32327988083)|
|wheel-manylinux-2014-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860832/job/32327986540)|
|wheel-manylinux-2014-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860624/job/32327984760)|
|wheel-manylinux-2014-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860851/job/32327985950)|
|wheel-manylinux-2014-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609861471/job/32327989324)|
|wheel-manylinux-2014-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609861473/job/32327989449)|
|wheel-manylinux-2014-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860812/job/32327985269)|
|wheel-manylinux-2014-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860971/job/32327986949)|
|wheel-manylinux-2014-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609861078/job/32327987566)|
|wheel-manylinux-2014-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609861606/job/32327989570)|
|wheel-manylinux-2014-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609861158/job/32327988001)|
|wheel-manylinux-2014-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609861142/job/32327987618)|
|wheel-manylinux-2014-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860191/job/32327982816)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860919/job/32327986344)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860605/job/32327984554)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860354/job/32327983482)|
|wheel-windows-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860398/job/32327983509)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11609860997/job/32327986996)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org