You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Guenter Knauf <ef...@gmx.net> on 2004/02/27 14:07:05 UTC
[PATCH] jki_shm.c revert code removal v1.35-v1.36
Hi all,
I would like to get the MMAP code back into CVS which was removed with version 1.36:
http://cvs.apache.org/viewcvs.cgi/jakarta-tomcat-connectors/jk/native2/common/jk_shm.c?r1=1.35&r2=1.36
This code would enable the scoreboard working on NetWare; and probably on other platforms too where mmap() support isnt in APR for whatever reason (Solaris?)
I've the problem that I cant compile Apache2 with APR_HAS_MMAP cause the mmap() support is new in the NetWare OS, and currently marked as experimental. Nevertheless it works with mod_jk2's scoreboard, and so would enable to test further with mod_jk2 on NetWare...
If this gets accepted I can provide also a patch.
thanks, Guenter.
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [PATCH] jki_shm.c revert code removal v1.35-v1.36
Posted by Guenter Knauf <ef...@gmx.net>.
Hi,
> jean-frederic clere wrote:
>> That is a work-around... The correct would be to fix APR.
sure, agreed;
and I work closely together with those maintaining Apache at Novell, as well as with the core OS folks; but I cant expect that I have mmap support in APR before the next half year...
> I agree, but let fix this problem in jk 2.0.4 and will remove it
> as soon as APR is fixed.
thanks, and I promise to provide another patch as soon as we get fixed APR and OS.
Guenter.
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [PATCH] jki_shm.c revert code removal v1.35-v1.36
Posted by Henri Gomez <hg...@apache.org>.
jean-frederic clere wrote:
> Henri Gomez wrote:
>
>>Guenter Knauf wrote:
>>
>>
>>>Hi,
>>>
>>>
>>>>Let's go Guenter, send the patch for review
>>>
>>>
>>>
>>>http://www.gknw.com/test/jk_shm.c.diff
>>
>>
>>Seems ok for me, I commit if nobody object...
>
>
> That is a work-around... The correct would be to fix APR.
I agree, but let fix this problem in jk 2.0.4 and will remove it
as soon as APR is fixed.
Let be Pragmatic :)
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [PATCH] jki_shm.c revert code removal v1.35-v1.36
Posted by jean-frederic clere <jf...@fujitsu-siemens.com>.
Henri Gomez wrote:
> Guenter Knauf wrote:
>
>> Hi,
>>
>>> Let's go Guenter, send the patch for review
>>
>>
>>
>> http://www.gknw.com/test/jk_shm.c.diff
>
>
> Seems ok for me, I commit if nobody object...
That is a work-around... The correct would be to fix APR.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>
>
Re: [PATCH] jki_shm.c revert code removal v1.35-v1.36
Posted by Henri Gomez <hg...@apache.org>.
Guenter Knauf wrote:
> Hi,
>
>>Let's go Guenter, send the patch for review
>
>
> http://www.gknw.com/test/jk_shm.c.diff
Seems ok for me, I commit if nobody object...
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [PATCH] jki_shm.c revert code removal v1.35-v1.36
Posted by Guenter Knauf <ef...@gmx.net>.
Hi,
> Let's go Guenter, send the patch for review
http://www.gknw.com/test/jk_shm.c.diff
thanks, Guenter.
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: [PATCH] jki_shm.c revert code removal v1.35-v1.36
Posted by Henri Gomez <hg...@apache.org>.
Guenter Knauf wrote:
> Hi all,
> I would like to get the MMAP code back into CVS which was removed with version 1.36:
> http://cvs.apache.org/viewcvs.cgi/jakarta-tomcat-connectors/jk/native2/common/jk_shm.c?r1=1.35&r2=1.36
>
> This code would enable the scoreboard working on NetWare; and probably on other platforms too where mmap() support isnt in APR for whatever reason (Solaris?)
>
> I've the problem that I cant compile Apache2 with APR_HAS_MMAP cause the mmap() support is new in the NetWare OS, and currently marked as experimental. Nevertheless it works with mod_jk2's scoreboard, and so would enable to test further with mod_jk2 on NetWare...
>
> If this gets accepted I can provide also a patch.
Let's go Guenter, send the patch for review
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org