You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2018/01/26 00:06:20 UTC

[GitHub] keith-turner commented on a change in pull request #366: ACCUMULO-4779 Speedup Property by precomputing and avoiding sync

keith-turner commented on a change in pull request #366: ACCUMULO-4779 Speedup Property by precomputing and avoiding sync
URL: https://github.com/apache/accumulo/pull/366#discussion_r164004677
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
 ##########
 @@ -629,6 +633,11 @@ public String getRawDefaultValue() {
    * @return default value
    */
   public String getDefaultValue() {
+    Preconditions.checkState(defaultValueComputed);
+    return computedDefaultValue;
+  }
+
+  private void precomputeDefaultValue() {
 
 Review comment:
   Currently the code calls isInterpolated() which does not work until the static block runs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services