You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2024/11/13 08:33:15 UTC

[PR] chore: Polish the debug output of capability [opendal]

Xuanwo opened a new pull request, #5315:
URL: https://github.com/apache/opendal/pull/5315

   # Which issue does this PR close?
   
   Nope
   
   # Rationale for this change
   
   The old debug output of capability requires multiple alloc.
   
   # What changes are included in this PR?
   
   This PR makes it zero cost and removes some not useful debug output.
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking-changes` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] chore: Polish the debug output of capability [opendal]

Posted by "codspeed-hq[bot] (via GitHub)" <gi...@apache.org>.
codspeed-hq[bot] commented on PR #5315:
URL: https://github.com/apache/opendal/pull/5315#issuecomment-2472848378

   ## [CodSpeed Performance Report](https://codspeed.io/apache/opendal/branches/polish-capability)
   
   ### Merging #5315 will **degrade performances by 15.89%**
   
   <sub>Comparing <code>polish-capability</code> (7310ef0) with <code>main</code> (7b18680)</sub>
   
   
   
   ### Summary
   
   `❌ 8` regressions
   `✅ 65` untouched benchmarks
   
   
   
   > :warning: _Please fix the performance issues or [acknowledge them on CodSpeed](https://codspeed.io/apache/opendal/branches/polish-capability)._
   
   ### Benchmarks breakdown
   
   |     | Benchmark | `main` | `polish-capability` | Change |
   | --- | --------- | ----------------------- | ------------------- | ------ |
   | ❌ | `buffer 256 KiB * 32 chunk` | 183.6 ns | 212.8 ns | -13.71% |
   | ❌ | `buffer 256 KiB * 4 chunk` | 154.4 ns | 183.6 ns | -15.89% |
   | ❌ | `buffer 4.00 MiB * 32 chunk` | 154.4 ns | 183.6 ns | -15.89% |
   | ❌ | `buffer 4.00 MiB * 4 chunk` | 154.4 ns | 183.6 ns | -15.89% |
   | ❌ | `256 KiB * 1000k truncate` | 245.8 ns | 275 ns | -10.61% |
   | ❌ | `256 KiB * 100k truncate` | 245.8 ns | 275 ns | -10.61% |
   | ❌ | `256 KiB * 10k truncate` | 245.8 ns | 275 ns | -10.61% |
   | ❌ | `256 KiB * 1k truncate` | 245.8 ns | 275 ns | -10.61% |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] chore: Polish the debug output of capability [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #5315:
URL: https://github.com/apache/opendal/pull/5315


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org