You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by "Skuperday (via GitHub)" <gi...@apache.org> on 2024/10/11 07:28:27 UTC

Re: [PR] changed weakFilter logic, so line charts will not disappear, while zoom [echarts]

Skuperday commented on code in PR #18202:
URL: https://github.com/apache/echarts/pull/18202#discussion_r1796539203


##########
test/axis-weak-filter.html:
##########


Review Comment:
   just test case that demonstrate diff in logic under weakFilter and without it



##########
src/component/dataZoom/AxisProxy.ts:
##########


Review Comment:
   add the new version of implement, that don't generate errors on eslinter



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org