You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "navinko (via GitHub)" <gi...@apache.org> on 2026/09/05 18:25:53 UTC
[PR] HDDS-16385. Minor cleanups in NodeDecommissionManager [ozone]
navinko opened a new pull request, #11211:
URL: https://github.com/apache/ozone/pull/11211
## What changes were proposed in this pull request?
Fix typo and remove redundant list copy in NodeDecommissionManager.
1: Fixed a typo in the InvalidHostStringException message in NodeDecommissionManager ("value hostname" → "valid hostname").
2. Simplified checkIfMaintenancePossible() to use `new ArrayList<>(dns)` instead of the redundant `stream().collect(Collectors.toList())` + `Collections.copy(...)`
Which is matching with other implementations like checkIfDecommissionPossible()
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16385
## How was this patch tested?
No behaviour changes, Ran existing unit tests in TestNodeDecommissionManager
Successful CI Build : https://github.com/navinko/ozone/actions/runs/33965658546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16385. Minor cleanups in NodeDecommissionManager [ozone]
Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel merged PR #11211:
URL: https://github.com/apache/ozone/pull/11211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16385. Minor cleanups in NodeDecommissionManager [ozone]
Posted by "navinko (via GitHub)" <gi...@apache.org>.
navinko commented on PR #11211:
URL: https://github.com/apache/ozone/pull/11211#issuecomment-5556626510
> Thanks for the patch! @navinko +1 LGTM.
Thanks @chihsuan for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16385. Minor cleanups in NodeDecommissionManager [ozone]
Posted by "navinko (via GitHub)" <gi...@apache.org>.
navinko commented on PR #11211:
URL: https://github.com/apache/ozone/pull/11211#issuecomment-5590959084
Thanks @sodonnel for merging the pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16385. Minor cleanups in NodeDecommissionManager [ozone]
Posted by "navinko (via GitHub)" <gi...@apache.org>.
navinko commented on PR #11211:
URL: https://github.com/apache/ozone/pull/11211#issuecomment-5588012742
Thanks @sodonnel for the review! The failing CI test (testValidateOverwrittenPaths) appears to be unrelated to these changes. Could you please re trigger the build once to see if it resolves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org