You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/30 08:49:13 UTC
[GitHub] [flink] ifndef-SleePy commented on a change in pull request #9221: [FLINK-13376][datastream] ContinuousFileReaderOperator should respect…
ifndef-SleePy commented on a change in pull request #9221: [FLINK-13376][datastream] ContinuousFileReaderOperator should respect…
URL: https://github.com/apache/flink/pull/9221#discussion_r308604404
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
##########
@@ -196,6 +197,17 @@ public void dispose() throws Exception {
public void close() throws Exception {
super.close();
+ waitReaderFinishing();
+
+ output.close();
+ }
+
+ @Override
+ public void endInput() throws Exception {
+ waitReaderFinishing();
Review comment:
I don't like the feel that fixing similar issues one by one :(
Let's discuss under JIRA ticket.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services